[refactor] hyperledger-iroha#132: refactor codegen for enum

Signed-off-by: Artemii Gerasimovich <[email protected]>

Author: QuentinI

Cargo.lock

@@ -14,14 +14,15 @@ name = "iroha2"
 crate-type = ["cdylib"]
 
 [dependencies]
-iroha_client = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-stable" }
-iroha_crypto = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-stable" }
-iroha_data_model = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-stable" }
-iroha_version = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-stable" }
+iroha_client = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-dev" }
+iroha_config = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-dev" }
+iroha_crypto = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-dev" }
+iroha_data_model = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-dev" }
+iroha_version = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-dev" }
 
 color-eyre = "0.6"
 parity-scale-codec = "3.1"
-pyo3 = { version = "0.16.4", features = ["extension-module", "multiple-pymethods"] }
+pyo3 = { version = "0.16.6", features = ["extension-module", "multiple-pymethods"] }
 pythonize = "0.16.0"
 serde = "1"
 serde_json = "1"

Cargo.toml

@@ -1,19 +1,21 @@
 {
-  "TORII_API_URL": "http://iroha0:8080",
-  "ACCOUNT_ID": {
-    "name": "alice",
-    "domain_id": {
-      "name": "wonderland"
-    }
+  "PUBLIC_KEY": "ed01207233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0",
+  "PRIVATE_KEY": {
+    "digest_function": "ed25519",
+    "payload": "9ac47abf59b356e0bd7dcbbbb4dec080e302156a48ca907e47cb6aea1d32719e7233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0"
   },
+  "ACCOUNT_ID": "alice@wonderland",
   "BASIC_AUTH": {
     "web_login": "mad_hatter",
     "password": "ilovetea"
   },
-  "PUBLIC_KEY": "ed01207233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0",
-  "PRIVATE_KEY": {
-    "digest_function": "ed25519",
-    "payload": "9ac47abf59b356e0bd7dcbbbb4dec080e302156a48ca907e47cb6aea1d32719e7233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0"
+  "TORII_API_URL": "http://127.0.0.1:8080",
+  "TORII_TELEMETRY_URL": "http://127.0.0.1:8180",
+  "TRANSACTION_TIME_TO_LIVE_MS": 100000,
+  "TRANSACTION_STATUS_TIMEOUT_MS": 15000,
+  "TRANSACTION_LIMITS": {
+    "max_instruction_number": 4096,
+    "max_wasm_size_bytes": 4194304
   },
-  "LOGGER_CONFIGURATION": {}
+  "ADD_TRANSACTION_NONCE": false
 }

example/config.json

@@ -7,12 +7,12 @@
 from iroha2.data_model.domain import Domain
 from iroha2.data_model.account import Account
 from iroha2.data_model import asset, account
-from iroha2.data_model.events import FilterBox, pipeline
+from iroha2.data_model.events import FilterBox, pipeline, Event
 from iroha2.crypto import KeyPair
 
 
 def wait_for_tx(cl: Client, hash: str):
-    filter = FilterBox.Pipeline(
+    filter = FilterBox(
         pipeline.EventFilter(
             entity_kind=pipeline.EntityKind.Transaction(),
             status_kind=None,
@@ -22,14 +22,13 @@ def wait_for_tx(cl: Client, hash: str):
     listener = cl.listen(filter)
 
     for event in listener:
-        if event.variant is event.Type.Pipeline:
-            if event.value.hash == hash:
-                if event.value.status.variant is pipeline.Status.Type.Committed:
-                    return
-                elif event.value.status.variant is pipeline.Status.Type.Validating:
-                    pass
-                else:
-                    raise RuntimeError(f"Tx rejected: {event.value.status}")
+        if isinstance(event, Event.Pipeline) and event.hash == hash:
+            if isinstance(event.status, pipeline.Status.Committed):
+                return
+            elif isinstance(event.status, pipeline.Status.Validating):
+                pass
+            else:
+                raise RuntimeError(f"Tx rejected: {event.value.status}")
 
 
 cfg = json.loads(open("./config.json").read())

example/test.py

@@ -9,11 +9,12 @@ license-file = "../../LICENSE"
 typing = []
 
 [dependencies]
-iroha_schema = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-stable" }
-iroha_schema_gen = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-stable" }
-iroha_data_model  = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-stable" }
+iroha_schema = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-dev" }
+iroha_schema_gen = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-dev" }
+iroha_data_model  = { git = "https://github.com/hyperledger/iroha", branch = "iroha2-dev" }
 
-color-eyre = "0.5"
+color-eyre = "0.6.2"
 serde_json = "1"
 either = "1.6"
 syn = { version = "1", features = ["full"] }
+topological-sort = "0.2.2"

generate/Cargo.toml

@@ -246,13 +246,23 @@ impl fmt::Display for UnnamedStructClass {
 
 impl fmt::Display for EnumClass {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        let typespec = self
+            .variants
+            .iter()
+            .map(|(_, pytype)| format!("get_class({pytype})"))
+            .collect::<Vec<_>>()
+            .join(", ");
         let variants = self
             .variants
             .iter()
-            .map(|(name, ty)| format!("(\"{}\", {})", name, ty))
+            .map(|(name, pytype)| format!("(\"{name}\", get_class({pytype}))"))
             .collect::<Vec<_>>()
             .join(", ");
-        write!(f, "{} = Enum[{}] ", self.name, variants)
+        writeln!(
+            f,
+            "{} = make_enum(\"{}\", [{variants}], typing.Union[{typespec}])",
+            self.name, self.name
+        )
     }
 }
 

generate/src/as_py.rs

@@ -99,7 +99,10 @@ impl Module {
         }
         writeln!(
             f,
-            "from .{}rust import Enum, make_struct, make_tuple, Dict",
+            r#"
+from .{}rust import make_enum, make_struct, make_tuple, get_class, SelfResolvingTypeVar, Dict
+import typing
+            "#,
             ".".repeat(r#in.mods.len())
         )?;
 
@@ -108,6 +111,8 @@ impl Module {
             Self::write_meta(&mut f, name.clone(), ty.clone())
                 .wrap_err_with(|| eyre!("Failed to write metadata for type {}", name))?;
         }
+
+        writeln!(f, "SelfResolvingTypeVar.resolve_all()")?;
         drop(f);
 
         for (name, either_module) in modules {

generate/src/module.rs

@@ -22,7 +22,7 @@ def submit_tx(self, tx: list):
         return self.cl.submit_all_with_metadata(tx, {})
 
     def submit_isi(self, isi):
-        return self.submit_tx([_Instruction(isi)])
+        return self.submit_tx([])
 
     def submit_tx_blocking(self, tx: list):
         tx = [i.to_rust() for i in tx]

iroha2/__init__.py

@@ -20,7 +20,8 @@ def __init__(self, id: Union[Id, str], logo: Optional[str] = None):
                          logo=logo,
                          accounts={},
                          asset_definitions={},
-                         metadata={})
+                         metadata={},
+                         asset_total_quantities={})
 
     def registrable(self):
         return _NewDomain(id=self.id, logo=self.logo, metadata={})

iroha2/data_model/domain/__init__.py

@@ -1 +1,5 @@
-from ..rust import Enum, make_struct, make_tuple, Dict
+
+from ..rust import make_enum, make_struct, make_tuple, get_class, SelfResolvingTypeVar, Dict
+import typing
+            
+SelfResolvingTypeVar.resolve_all()