fix: Allow different app version when downloading via plugin if setting is off #2579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brosssh
added
the
ReVanced Manager Compose
4 tasks
Axelen123
requested changes
May 30, 2025
|
Uhm I see. Since the user select the patches before downloading the APK, is there an "easy" way so that we can allow diffent version while still keeping the compatibility check? |
|
Why is that needed? The version defined by ReVanced Manager by default is the latest that supports the patches, why would one want an older version? Nevertheless, if the user really wants to pick a different version then they can disable the check |
|
I don't understand the issues mentioned here. But users can select patches, based on it, a suggested version is calculated, which is enforced as long as the switch to disable this enforcement is on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2578.