Skip to content

Commit 4af6d5a

Browse files
committed
Code refactor and package changes.
1 parent 7ba1f48 commit 4af6d5a

File tree

13 files changed

+35
-33
lines changed

13 files changed

+35
-33
lines changed

src/main/java/com/khomsi/game/entity/npc/object/NpcRock.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
import com.khomsi.game.entity.Entity;
55
import com.khomsi.game.objects.outside.DungeonDoorClosedObject;
66
import com.khomsi.game.objects.outside.DungeonDoorOpenedObject;
7-
import com.khomsi.game.tilesinteractive.InteractiveTile;
8-
import com.khomsi.game.tilesinteractive.SwitchPress;
7+
import com.khomsi.game.tiles.interactive.InteractiveTile;
8+
import com.khomsi.game.tiles.interactive.SwitchPress;
99

1010
import java.awt.*;
1111
import java.util.Arrays;

src/main/java/com/khomsi/game/main/GameManager.java

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313
import com.khomsi.game.main.logic.EventHandler;
1414
import com.khomsi.game.main.tools.EntityComparator;
1515
import com.khomsi.game.main.tools.KeyHandler;
16-
import com.khomsi.game.main.tools.PlaceObjects;
1716
import com.khomsi.game.main.tools.Sound;
1817
import com.khomsi.game.main.tools.ui.UI;
18+
import com.khomsi.game.objects.PlaceObjects;
1919
import com.khomsi.game.tiles.Map;
2020
import com.khomsi.game.tiles.TileManager;
21-
import com.khomsi.game.tilesinteractive.InteractiveTile;
21+
import com.khomsi.game.tiles.interactive.InteractiveTile;
2222

2323
import javax.swing.*;
2424
import java.awt.*;
@@ -221,10 +221,6 @@ public void update() {
221221
if (npc != null)
222222
npc.update();
223223

224-
for (Entity animated : animatedTiles[currentMap])
225-
if (animated != null)
226-
animated.update();
227-
228224
//Mob loop
229225
for (int i = 0; i < mobs[1].length; i++) {
230226
if (mobs[currentMap][i] != null) {
@@ -256,6 +252,10 @@ public void update() {
256252
tile.update();
257253
}
258254
}
255+
for (Entity animated : animatedTiles[currentMap])
256+
if (animated != null)
257+
animated.update();
258+
259259
enManagement.update();
260260
}
261261
if (gameState == PAUSE_STATE) {
@@ -281,14 +281,11 @@ else if (gameState == MAP_STATE) {
281281
else {
282282
//Draw Tiles
283283
tileManager.draw(g2d);
284-
for (Entity element : interactTile[currentMap]) {
285-
if (element != null)
286-
element.draw(g2d);
287-
}
284+
drawObjectsOnScreen(interactTile);
285+
drawObjectsOnScreen(animatedTiles);
288286
entities.add(player);
289287
//Add and render npc, obj, mobs, projectiles to draw list
290288
drawMethodArray(npcList);
291-
drawMethodArray(animatedTiles);
292289
drawMethodArray(object);
293290
drawMethodArray(mobs);
294291
//Interactive tiles
@@ -316,6 +313,13 @@ else if (gameState == MAP_STATE) {
316313
debugFunction(g2d, drawStart);
317314
}
318315

316+
private void drawObjectsOnScreen(Entity[][] animatedTiles) {
317+
for (Entity element : animatedTiles[currentMap]) {
318+
if (element != null)
319+
element.draw(g2d);
320+
}
321+
}
322+
319323
private void drawMethodList(List<Entity> list) {
320324
for (Entity object : list) {
321325
if (object != null)

src/main/java/com/khomsi/game/main/tools/PlaceObjects.java renamed to src/main/java/com/khomsi/game/objects/PlaceObjects.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.khomsi.game.main.tools;
1+
package com.khomsi.game.objects;
22

33
import com.khomsi.game.data.GameProgress;
44
import com.khomsi.game.entity.mobs.*;
@@ -15,11 +15,11 @@
1515
import com.khomsi.game.objects.light.LanternObject;
1616
import com.khomsi.game.objects.outside.*;
1717
import com.khomsi.game.objects.spells.PotionObject;
18-
import com.khomsi.game.tilesinteractive.Bush;
19-
import com.khomsi.game.tilesinteractive.DestructibleWall;
20-
import com.khomsi.game.tilesinteractive.SwitchPress;
21-
import com.khomsi.game.tilesanimated.water.WaterBubbles;
22-
import com.khomsi.game.tilesanimated.water.WaterHurricane;
18+
import com.khomsi.game.tiles.interactive.Bush;
19+
import com.khomsi.game.tiles.interactive.DestructibleWall;
20+
import com.khomsi.game.tiles.interactive.SwitchPress;
21+
import com.khomsi.game.tiles.animated.water.WaterBubbles;
22+
import com.khomsi.game.tiles.animated.water.WaterHurricane;
2323

2424
public class PlaceObjects {
2525
GameManager gameManager;

src/main/java/com/khomsi/game/tilesanimated/AnimatedTile.java renamed to src/main/java/com/khomsi/game/tiles/animated/AnimatedTile.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.khomsi.game.tilesanimated;
1+
package com.khomsi.game.tiles.animated;
22

33
import com.khomsi.game.entity.Entity;
44
import com.khomsi.game.main.GameManager;
@@ -9,8 +9,6 @@ public class AnimatedTile extends Entity {
99
public AnimatedTile(GameManager gameManager) {
1010
super(gameManager);
1111
this.gameManager = gameManager;
12-
direction = "down";
13-
speed = 0;
1412
}
1513

1614
@Override

src/main/java/com/khomsi/game/tilesanimated/water/WaterBubbles.java renamed to src/main/java/com/khomsi/game/tiles/animated/water/WaterBubbles.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package com.khomsi.game.tilesanimated.water;
1+
package com.khomsi.game.tiles.animated.water;
22

33
import com.khomsi.game.main.GameManager;
4-
import com.khomsi.game.tilesanimated.AnimatedTile;
4+
import com.khomsi.game.tiles.animated.AnimatedTile;
55

66
public class WaterBubbles extends AnimatedTile {
77
public WaterBubbles(GameManager gameManager) {

src/main/java/com/khomsi/game/tilesanimated/water/WaterHurricane.java renamed to src/main/java/com/khomsi/game/tiles/animated/water/WaterHurricane.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package com.khomsi.game.tilesanimated.water;
1+
package com.khomsi.game.tiles.animated.water;
22

33
import com.khomsi.game.main.GameManager;
4-
import com.khomsi.game.tilesanimated.AnimatedTile;
4+
import com.khomsi.game.tiles.animated.AnimatedTile;
55

66
public class WaterHurricane extends AnimatedTile {
77
public WaterHurricane(GameManager gameManager) {

src/main/java/com/khomsi/game/tilesinteractive/Bush.java renamed to src/main/java/com/khomsi/game/tiles/interactive/Bush.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.khomsi.game.tilesinteractive;
1+
package com.khomsi.game.tiles.interactive;
22

33
import com.khomsi.game.main.GameManager;
44
import com.khomsi.game.entity.Entity;

src/main/java/com/khomsi/game/tilesinteractive/DestructibleWall.java renamed to src/main/java/com/khomsi/game/tiles/interactive/DestructibleWall.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.khomsi.game.tilesinteractive;
1+
package com.khomsi.game.tiles.interactive;
22

33
import com.khomsi.game.main.GameManager;
44
import com.khomsi.game.objects.interact.CoinBObject;

src/main/java/com/khomsi/game/tilesinteractive/DryTree.java renamed to src/main/java/com/khomsi/game/tiles/interactive/DryTree.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.khomsi.game.tilesinteractive;
1+
package com.khomsi.game.tiles.interactive;
22

33
import com.khomsi.game.entity.Entity;
44
import com.khomsi.game.main.GameManager;

src/main/java/com/khomsi/game/tilesinteractive/InteractiveTile.java renamed to src/main/java/com/khomsi/game/tiles/interactive/InteractiveTile.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.khomsi.game.tilesinteractive;
1+
package com.khomsi.game.tiles.interactive;
22

33
import com.khomsi.game.main.GameManager;
44
import com.khomsi.game.entity.Entity;

0 commit comments

Comments
 (0)