Skip to content

Missing declaration of function in header file | S2LP Library #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roshangeoroy opened this issue Jan 28, 2025 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@roshangeoroy
Copy link

Set-up

  • Hardware: NUCLEOF401RE with S2868A2 expansion board
  • Software: STM CUBE IDE 1.15.0

The Bug
The function void S2LPPktStackSeqNumForReload(uint8_t cReloadValue) in the file: S2LP_PktStack.c is not declared in the corresponding header file: S2LP_PktStack.h

This causes implicit declaration warnings when attempting to use the function in other parts of the application.


Steps to Reproduce:

  • Build an example project (eg. S2868A2_P2P)
  • Add the function S2LPPktStackSeqNumForReload(uint8_t cReloadValue) in your application.
  • Compile the project.
  • Observe the warning: "implicit declaration of function 'S2LPPktStackSeqNumForReload'".

Proposed Fix:
Add the following function prototype in the header file:

/**
 * @brief Function to reload the sequence number.
 * @param cReloadValue: Reload value for the sequence number.
 * @retval None
 */
void S2LPPktStackSeqNumForReload(uint8_t cReloadValue);
@mgrella mgrella self-assigned this Jan 28, 2025
@mgrella
Copy link
Collaborator

mgrella commented Jan 28, 2025

Hello @roshangeoroy ,

thank you very for your contribution, I acknowledge your comment.
Your suggestion will be integrated in the next version of the X-CUBE-SUBG2.

BR,
Marco

@mgrella mgrella added the enhancement New feature or request label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants