From 9487c9b0f372e9b919b294c09945670ec523c835 Mon Sep 17 00:00:00 2001 From: Atul Rajput <92659293+AtulRajput01@users.noreply.github.com> Date: Tue, 20 Jun 2023 09:23:18 +0530 Subject: [PATCH 1/2] Create PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 33 ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..ec45d4e2 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,33 @@ + + +## 🛠️ Issue (Number) + + +Closes # + +# Description + +Please include a summary of the change. Please also include relevant motivation and context. + +## Type of change + + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) +- [ ] This change requires a documentation update + +# Checklist: + + +- [ ] I have made this from my own +- [ ] I have taken help from some online resourses +- [ ] My code follows the style guidelines of this project +- [ ] I have performed a self-review of my own code +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have made corresponding changes to the documentation +- [ ] My changes generate no new warnings +- [ ] The title of my pull request is a short description of the requested changes. + + +# ATTACH SCREEN-SHOTS From 8316168864154932b5337963bfd21021f082e101 Mon Sep 17 00:00:00 2001 From: Atul Rajput <92659293+AtulRajput01@users.noreply.github.com> Date: Wed, 21 Jun 2023 18:05:31 +0530 Subject: [PATCH 2/2] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ec45d4e2..b3554f14 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,27 +7,13 @@ Closes # # Description -Please include a summary of the change. Please also include relevant motivation and context. + ## Type of change - - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - -# Checklist: - - -- [ ] I have made this from my own -- [ ] I have taken help from some online resourses -- [ ] My code follows the style guidelines of this project -- [ ] I have performed a self-review of my own code -- [ ] I have commented my code, particularly in hard-to-understand areas -- [ ] I have made corresponding changes to the documentation -- [ ] My changes generate no new warnings -- [ ] The title of my pull request is a short description of the requested changes. - - -# ATTACH SCREEN-SHOTS +- [ ] I have added smoke tests. +- [ ] Newly added and existing smoke tests pass locally with my changes.