From 1b8f51e2e09726f7d68901a1fe5130d9686b50c8 Mon Sep 17 00:00:00 2001 From: ArnoStrouwen Date: Sun, 3 Mar 2024 22:09:47 +0100 Subject: [PATCH 1/5] automated format PR --- .github/workflows/FormatCheck.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/FormatCheck.yml b/.github/workflows/FormatCheck.yml index dd55150..f3e1088 100644 --- a/.github/workflows/FormatCheck.yml +++ b/.github/workflows/FormatCheck.yml @@ -1,11 +1,6 @@ name: format-check on: - push: - branches: - - 'master' - - 'release-' - tags: '*' pull_request: jobs: @@ -40,3 +35,8 @@ jobs: write(stdout, out) exit(1) end' + - uses: reviewdog/action-suggester@v1 + with: + tool_name: JuliaFormatter + fail_on_error: true + filter_mode: added \ No newline at end of file From 9fcb85201473f1c02a8ff93cc4c440d6b0e1f9fc Mon Sep 17 00:00:00 2001 From: ArnoStrouwen Date: Sun, 3 Mar 2024 22:10:03 +0100 Subject: [PATCH 2/5] style mistake to test out automated PR --- src/krylov_phiv.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/krylov_phiv.jl b/src/krylov_phiv.jl index eb34145..48f07ed 100644 --- a/src/krylov_phiv.jl +++ b/src/krylov_phiv.jl @@ -12,7 +12,7 @@ function Base.resize!(C::ExpvCache{T}, maxiter::Int) where {T} end function get_cache(C::ExpvCache, m::Int) m^2 > length(C.mem) && resize!(C, m) # resize the cache if needed - reshape(@view(C.mem[1:(m^2)]), m, m) + reshape(@view(C.mem[1:(m^2)]), m,m) end ############################ From 0b57d8e39526aa0f2d098a1ec87be12bb785e9af Mon Sep 17 00:00:00 2001 From: ArnoStrouwen Date: Sun, 3 Mar 2024 22:17:31 +0100 Subject: [PATCH 3/5] remove erroring if not formatted properly --- .github/workflows/FormatCheck.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/FormatCheck.yml b/.github/workflows/FormatCheck.yml index f3e1088..6af1cde 100644 --- a/.github/workflows/FormatCheck.yml +++ b/.github/workflows/FormatCheck.yml @@ -24,17 +24,6 @@ jobs: run: | julia -e 'using Pkg; Pkg.add(PackageSpec(name="JuliaFormatter"))' julia -e 'using JuliaFormatter; format(".", verbose=true)' - - name: Format check - run: | - julia -e ' - out = Cmd(`git diff --name-only`) |> read |> String - if out == "" - exit(0) - else - @error "Some files have not been formatted !!!" - write(stdout, out) - exit(1) - end' - uses: reviewdog/action-suggester@v1 with: tool_name: JuliaFormatter From 07a2899d30a6fbc2c3ae7e6f8e45002a5a17702f Mon Sep 17 00:00:00 2001 From: ArnoStrouwen Date: Sun, 3 Mar 2024 22:30:08 +0100 Subject: [PATCH 4/5] try github token --- .github/workflows/FormatCheck.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/FormatCheck.yml b/.github/workflows/FormatCheck.yml index 6af1cde..eed9e81 100644 --- a/.github/workflows/FormatCheck.yml +++ b/.github/workflows/FormatCheck.yml @@ -26,6 +26,7 @@ jobs: julia -e 'using JuliaFormatter; format(".", verbose=true)' - uses: reviewdog/action-suggester@v1 with: + github_token: ${{ secrets.GITHUB_TOKEN }} tool_name: JuliaFormatter fail_on_error: true filter_mode: added \ No newline at end of file From c6082b7d8aae90f42fd514fb841fa28c76960836 Mon Sep 17 00:00:00 2001 From: ArnoStrouwen Date: Sun, 3 Mar 2024 22:32:40 +0100 Subject: [PATCH 5/5] try documenter token --- .github/workflows/FormatCheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/FormatCheck.yml b/.github/workflows/FormatCheck.yml index eed9e81..c803784 100644 --- a/.github/workflows/FormatCheck.yml +++ b/.github/workflows/FormatCheck.yml @@ -26,7 +26,7 @@ jobs: julia -e 'using JuliaFormatter; format(".", verbose=true)' - uses: reviewdog/action-suggester@v1 with: - github_token: ${{ secrets.GITHUB_TOKEN }} + github_token: ${{ secrets.DOCUMENTER_KEY }} tool_name: JuliaFormatter fail_on_error: true filter_mode: added \ No newline at end of file