Use enum for oprations

Author: SuhelMakkad

src/common/components/results-table/tool-bar/filter/schema.ts

@@ -1,18 +1,27 @@
 import { z } from "zod";
 
+export const operators = {
+  GREATER_THAN: "gt",
+  LESS_THAN: "lt",
+  GREATER_THAN_EQUAL: "gte",
+  LESS_THAN_EQUAL: "lte",
+  EQUAL: "eq",
+  NOT_EQUAL: "ne",
+};
+
 export const filedOptions = [
   { label: "Marks", value: "marks" },
   { label: "AIR", value: "air" },
   { label: "Application No.", value: "id" },
 ];
 
 export const operatorOptions = [
-  { label: ">", value: "gt" },
-  { label: "<", value: "lt" },
-  { label: ">=", value: "gte" },
-  { label: "<=", value: "lte" },
-  { label: "=", value: "eq" },
-  { label: "!=", value: "ne" },
+  { label: ">", value: operators.GREATER_THAN },
+  { label: "<", value: operators.LESS_THAN },
+  { label: ">=", value: operators.GREATER_THAN_EQUAL },
+  { label: "<=", value: operators.LESS_THAN_EQUAL },
+  { label: "=", value: operators.EQUAL },
+  { label: "!=", value: operators.NOT_EQUAL },
 ];
 
 export const defaultState = {

src/common/utils/worker/results.ts

@@ -1,8 +1,8 @@
 import { expose } from "comlink";
 import { get24Results } from "@/api/index";
 import { DATA_PER_PAGE } from "@/utils/constants";
+import { operators, type FiltersSchema } from "@/components/results-table/tool-bar/filter/schema";
 import type { Result } from "@/utils/types";
-import type { FiltersSchema } from "@/components/results-table/tool-bar/filter/schema";
 
 type GetResultsParams = {
   pageNo: number;
@@ -42,17 +42,17 @@ export class Results {
         if (!fieldValue) return false;
 
         switch (operator) {
-          case "gt":
+          case operators.GREATER_THAN:
             return fieldValue > value;
-          case "lt":
+          case operators.LESS_THAN:
             return fieldValue < value;
-          case "gte":
+          case operators.GREATER_THAN_EQUAL:
             return fieldValue >= value;
-          case "lte":
+          case operators.LESS_THAN_EQUAL:
             return fieldValue <= value;
-          case "eq":
+          case operators.EQUAL:
             return fieldValue === value;
-          case "ne":
+          case operators.NOT_EQUAL:
             return fieldValue !== value;
           default:
             return false;