Fix issues found by cargo clippy (#456)

Temporarily disable tquic-interop-main workflow

Author: iyangsj

.github/workflows/tquic-interop-main.yaml

@@ -1,10 +1,10 @@
 name: Interop
 
 on:
-  push:
-    branches: [ "develop" ]
-  pull_request:
-    branches: [ "develop" ]
+#  push:
+#    branches: [ "develop" ]
+#  pull_request:
+#    branches: [ "develop" ]
   workflow_dispatch:
 
 env:

src/endpoint.rs

@@ -178,7 +178,7 @@ impl Endpoint {
         }
 
         // Update the connection route.
-        if scid.len() > 0 {
+        if !scid.is_empty() {
             self.routes.insert_with_cid(scid, idx);
         } else {
             self.routes
@@ -890,7 +890,7 @@ impl ConnectionRoutes {
     /// Find the target connection for the incoming datagram.
     fn find(&self, dcid: &ConnectionId, buf: &mut [u8], info: &PacketInfo) -> (Option<&u64>, bool) {
         let mut reset = false;
-        let mut idx = if dcid.len() > 0 {
+        let mut idx = if !dcid.is_empty() {
             // The packet has a non-zero-length Destination Connection ID
             // corresponding to an existing connection.
             self.cid_table.get(dcid)

src/h3/error.rs

@@ -135,7 +135,7 @@ impl Http3Error {
             Http3Error::QpackDecoderStreamError => 0x202,
             Http3Error::TransportError { .. } => 0x102,
             Http3Error::StreamBlocked => 0x102,
-            Http3Error::Done { .. } => 0x102,
+            Http3Error::Done => 0x102,
         }
     }
 

src/packet.rs

@@ -783,6 +783,7 @@ pub fn verify_retry_integrity_tag(buf: &mut [u8], odcid: &[u8], version: u32) ->
 
     let hdr_buf = &buf[..buf.len() - len];
     let tag = compute_retry_integrity_tag(hdr_buf, odcid, version)?;
+    #[allow(deprecated)]
     ring::constant_time::verify_slices_are_equal(&buf[buf.len() - len..], tag.as_ref())
         .map_err(|_| Error::CryptoFail)?;
 

tools/src/bin/tquic_client.rs

@@ -691,7 +691,7 @@ impl Worker {
                 self.end_time = Some(Instant::now());
             }
 
-            if senders.len() == 0 {
+            if senders.is_empty() {
                 // All connections are closed.
                 return Ok(true);
             }