From b4d28586e7a06ea3fde2758dcd40c79c8663a7ce Mon Sep 17 00:00:00 2001 From: Dominik Gehl Date: Sun, 16 Feb 2025 15:17:04 +0100 Subject: [PATCH 1/2] Updated documentation with regard to poetry shell #5509 --- CONTRIBUTING.md | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fa4f2cdab9..c1206b6f1c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,10 +19,13 @@ You can follow these steps: 1. Make sure you have Poetry installed ([see instructions here](https://python-poetry.org)) 2. Clone the Textual repository - 3. Run `poetry shell` to create a virtual environment for the dependencies - 4. Run `make setup` to install all dependencies - 5. Make sure the latest version of Textual was installed by running the command `textual --version` - 6. Install the pre-commit hooks with the command `pre-commit install` + 3. Run `cd textual` to make textual your current working directory + 4. Run `python -m venv .venv` to create a new python virtual environment + 5. Run `source .venv/bin/activate` to activate the virtual environment + 6. Run `python -m pip install poetry` to install poetry + 7. Run `make setup` to install all dependencies + 8. Make sure the latest version of Textual was installed by running the command `textual --version` + 9. Install the pre-commit hooks with the command `pre-commit install` ([Read this](#makefile-commands) if the command `make` doesn't work for you.) From 18a5037bd077e6539ab17039d5d553f88d1fd3a5 Mon Sep 17 00:00:00 2001 From: Dominik Gehl Date: Sat, 8 Mar 2025 08:34:00 +0100 Subject: [PATCH 2/2] Updated documentation with regard to poetry shell installation #5509 --- CONTRIBUTING.md | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c1206b6f1c..7d3f5d64bd 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,13 +19,10 @@ You can follow these steps: 1. Make sure you have Poetry installed ([see instructions here](https://python-poetry.org)) 2. Clone the Textual repository - 3. Run `cd textual` to make textual your current working directory - 4. Run `python -m venv .venv` to create a new python virtual environment - 5. Run `source .venv/bin/activate` to activate the virtual environment - 6. Run `python -m pip install poetry` to install poetry - 7. Run `make setup` to install all dependencies - 8. Make sure the latest version of Textual was installed by running the command `textual --version` - 9. Install the pre-commit hooks with the command `pre-commit install` + 3. Run `poetry shell` to create a virtual environment for the dependencies. If your poetry installation doesn't have `shell` command, first install the `shell` plugin using `poetry self add poetry-plugin-shell`. + 4. Run `make setup` to install all dependencies + 5. Make sure the latest version of Textual was installed by running the command `textual --version` + 6. Install the pre-commit hooks with the command `pre-commit install` ([Read this](#makefile-commands) if the command `make` doesn't work for you.)