Skip to content

Exercise 6 repeat string: Put info about .skip tests in readme #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 of 5 tasks
Jacksonbryan28 opened this issue May 7, 2025 · 0 comments
Open
4 of 5 tasks
Labels
Status: Needs Review This issue/PR needs an initial or additional review

Comments

@Jacksonbryan28
Copy link

Prerequisites

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • I have searched the existing issues to ensure this improvement hasn't been suggested before (please have a look through our open issues list to make sure)
  • The title of this issue follows the <Location of the improvement>: <Brief description of the improvement> format, e.g. Exercises: Add exercise on XYZ
  • (Optional) I am interested in working on this issue and would like to be assigned to it

Improvement Description

In the javascript-exercises file you pick up on lesson 6. In the lesson 7 readme there is the following paragraph -

You will notice in this exercise that there are multiple tests (in the file reverseString.spec.js). Currently, only the first test is enabled. After ensuring that the first test passes, enable the remaining tests one by one by removing the .skip from the test.skip() function.

I suggest moving this into lesson 6 since lesson 6 also has multiple test with .skip applied. I wasn't sure what to do, or why so many tests were being skipped when running npm test for lesson 6.

Acceptance Criteria

  • the paragraph explaining .skip and how to use multiple skips is moved from lesson 7 into lesson 6 so it appears when you first encounter it.

(Optional) Additional Comments

No response

@Jacksonbryan28 Jacksonbryan28 added the Status: Needs Review This issue/PR needs an initial or additional review label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This issue/PR needs an initial or additional review
Projects
None yet
Development

No branches or pull requests

1 participant