-
Notifications
You must be signed in to change notification settings - Fork 82
large premetric spaces #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
large premetric spaces #1426
Conversation
There's still a lot to do but is it the kind of things you had in mind @fredrik-bakke ? |
This looks great! |
Maybe call it a rational neighborhood relation or rational neighborhood structure? |
We also should'nt have inconsistent naming between the small and large setup though, but Im okay with leaving the second renaming for a second pr, to slice things up |
And then a (old) premetric space is |
of course! But instead of rewriting the small setup directly I thought I could try to write the large setup with the new naming scheme, until we all agree, and then adapt the small setup to the new names.
yeah, this mass renaming has me a bit concerned. I guess we could do it in parallel PRs and merge them when they're both ready. |
TBH I'm not a big fan of this name. It's like calling a magma a "Type-With-Binary-Operation"; it's descriptive, but it's not a name, it's a description. I think we could actually do without, e.g.
|
No description provided.