Skip to content

large premetric spaces #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

malarbol
Copy link
Collaborator

@malarbol malarbol commented May 8, 2025

No description provided.

@malarbol malarbol self-assigned this May 8, 2025
@malarbol malarbol removed their assignment May 8, 2025
@malarbol
Copy link
Collaborator Author

malarbol commented May 8, 2025

There's still a lot to do but is it the kind of things you had in mind @fredrik-bakke ?
This also serves as suggestions for renaming/removing things of standard metric spaces (e.g. rename Premetric to Rational-Neighborhood, remove Pseudometric-Space and only keep premetric and metric spaces etc.

@fredrik-bakke
Copy link
Collaborator

This looks great!

@fredrik-bakke
Copy link
Collaborator

Maybe call it a rational neighborhood relation or rational neighborhood structure?

@fredrik-bakke
Copy link
Collaborator

We also should'nt have inconsistent naming between the small and large setup though, but Im okay with leaving the second renaming for a second pr, to slice things up

@fredrik-bakke
Copy link
Collaborator

fredrik-bakke commented May 9, 2025

And then a (old) premetric space is Type-With-Rational-Neighborhoods

@malarbol
Copy link
Collaborator Author

malarbol commented May 9, 2025

We also should'nt have inconsistent naming between the small and large setup though,

of course! But instead of rewriting the small setup directly I thought I could try to write the large setup with the new naming scheme, until we all agree, and then adapt the small setup to the new names.

but Im okay with leaving the second renaming for a second pr, to slice things up

yeah, this mass renaming has me a bit concerned. I guess we could do it in parallel PRs and merge them when they're both ready.

@malarbol
Copy link
Collaborator Author

malarbol commented May 9, 2025

And then a (old) premetric space is Type-With-Rational-Neighborhoods

TBH I'm not a big fan of this name. It's like calling a magma a "Type-With-Binary-Operation"; it's descriptive, but it's not a name, it's a description. I think we could actually do without, e.g.

  • Rational-Neighborhood-Relation;
  • Premetric-Structure (Rational-Neighborhood-Relation with some properties);
  • Premetric-Space (type with a Premetric-Structure);
  • Metric-Space (Premetric-Space with some properties).

@malarbol malarbol mentioned this pull request May 18, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants