fix(views:about): default text for adb version
#918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the method signature to allow the consumer to decide when/if and how to parse the `stdout`
regression introduced here: 3cc2f1d
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in the ADB version display on the About page while also improving performance by simplifying how the ADB version is parsed and returned.
- Simplifies the ADB version extraction in the GUI view
- Changes the ADB version function to return a String instead of a vector of lines
- Adds debug assertions in the ADB command for output validation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gui/views/about.rs | Updates version text extraction and error handling |
| src/core/adb.rs | Changes the version function return type and refines assertions |
Comments suppressed due to low confidence (1)
src/gui/views/about.rs:102
- Consider handling the case when the version string does not contain any newline more gracefully instead of using unreachable!(), which could result in a panic in release builds.
.nth(0)
.unwrap_or_else(|| unreachable!())
|
Copilot is wrong about the assertions. I just refactored them into their own |
|
Forgot the screenshots: |
adhirajsinghchauhan
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adb version#894versioninternal API: pre-parsing isn't necessary, because the only caller ignores all lines but the first one