allow beatmap conversion between non-std rulesets

Supersedes ppy#23875, fix ppy#9263

Gives the ruleset full control which maps to show both with and without converts enabled - e.g. a competitive/harder version ruleset such as for mania could make mania maps show without enabling converts, as well as control which ones to support only if conversions are enabled in the settings.

There is a CanConvert function in BeatmapConverter which I considered using as well, however it looks like this beatmap converter isn't directly accessible in the carousel and adding it may be quite severe on performance impact.

This way, maps may also show if they fail in conversion, but playing them will show a notification that the maps aren't playable. For the future an async task that just goes through maps to try and see if they are convertible for different modes and caches that might be useful. (e.g. generally mania->taiko converts might be good to have, but a quality control function inside CanConvert could make the conversion fail if it's unplayable)

This enables the following additional conversions since in my small testing using the default bundled osu maps they worked quite well:

ctb -> mania (gives surprisingly fun beginner 7k maps)
ctb -> taiko

If wanted I can also move this into a new interface, however I think the FilterCriteria interface fits quite well actually

Author: WebFreak001

osu.Game.Rulesets.Catch/CatchFilterCriteria.cs

@@ -0,0 +1,33 @@
+// Copyright (c) ppy Pty Ltd <[email protected]>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using System.Collections.Generic;
+using osu.Framework.Bindables;
+using osu.Game.Beatmaps;
+using osu.Game.Rulesets.Filter;
+using osu.Game.Rulesets.Mods;
+using osu.Game.Screens.Select;
+using osu.Game.Screens.Select.Filter;
+
+namespace osu.Game.Rulesets.Catch
+{
+    public class CatchFilterCriteria : IRulesetFilterCriteria
+    {
+        public bool Matches(BeatmapInfo beatmapInfo, FilterCriteria criteria)
+        {
+            return beatmapInfo.Ruleset.ShortName == "fruits"
+                || (criteria.AllowConvertedBeatmaps && (
+                    beatmapInfo.Ruleset.ShortName == "osu"));
+        }
+
+        public bool TryParseCustomKeywordCriteria(string key, Operator op, string value)
+        {
+            return false;
+        }
+
+        public bool FilterMayChangeFromMods(ValueChangedEvent<IReadOnlyList<Mod>> mods)
+        {
+            return false;
+        }
+    }
+}

osu.Game.Rulesets.Catch/CatchRuleset.cs

@@ -24,6 +24,7 @@
 using osu.Game.Rulesets.Catch.UI;
 using osu.Game.Rulesets.Difficulty;
 using osu.Game.Rulesets.Edit;
+using osu.Game.Rulesets.Filter;
 using osu.Game.Rulesets.Mods;
 using osu.Game.Rulesets.Replays.Types;
 using osu.Game.Rulesets.Scoring;
@@ -49,6 +50,8 @@ public class CatchRuleset : Ruleset, ILegacyRuleset
 
         public override IBeatmapProcessor CreateBeatmapProcessor(IBeatmap beatmap) => new CatchBeatmapProcessor(beatmap);
 
+        public override IRulesetFilterCriteria CreateRulesetFilterCriteria() => new CatchFilterCriteria();
+
         public const string SHORT_NAME = "fruits";
 
         public override string RulesetAPIVersionSupported => CURRENT_RULESET_API_VERSION;

osu.Game.Rulesets.Mania/ManiaFilterCriteria.cs

@@ -21,7 +21,22 @@ public class ManiaFilterCriteria : IRulesetFilterCriteria
 
         public bool Matches(BeatmapInfo beatmapInfo, FilterCriteria criteria)
         {
-            return !keys.HasFilter || keys.IsInRange(ManiaBeatmapConverter.GetColumnCount(LegacyBeatmapConversionDifficultyInfo.FromBeatmapInfo(beatmapInfo), criteria.Mods));
+            // taiko maps currently don't yet convert very well to mania
+            if (!criteria.AllowConvertedBeatmaps || beatmapInfo.Ruleset.ShortName == "taiko")
+                return false;
+            return (beatmapInfo.Ruleset.ShortName == "mania"
+                    || (criteria.AllowConvertedBeatmaps && (
+                        beatmapInfo.Ruleset.ShortName == "osu" ||
+                        beatmapInfo.Ruleset.ShortName == "fruits"))
+                ) && (!keys.HasFilter
+                    || keys.IsInRange(
+                        ManiaBeatmapConverter.GetColumnCount(
+                            LegacyBeatmapConversionDifficultyInfo.FromBeatmapInfo(
+                                beatmapInfo
+                            ), criteria.Mods
+                        )
+                    )
+                );
         }
 
         public bool TryParseCustomKeywordCriteria(string key, Operator op, string value)

osu.Game.Rulesets.Osu/OsuFilterCriteria.cs

@@ -0,0 +1,34 @@
+// Copyright (c) ppy Pty Ltd <[email protected]>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using System.Collections.Generic;
+using osu.Framework.Bindables;
+using osu.Game.Beatmaps;
+using osu.Game.Rulesets.Filter;
+using osu.Game.Rulesets.Mods;
+using osu.Game.Screens.Select;
+using osu.Game.Screens.Select.Filter;
+
+namespace osu.Game.Rulesets.Osu
+{
+    public class OsuFilterCriteria : IRulesetFilterCriteria
+    {
+        public bool Matches(BeatmapInfo beatmapInfo, FilterCriteria criteria)
+        {
+            // for std osu, don't allow any conversions from other modes
+            // (maybe we could allow CtB in the future since the converted maps
+            // are surpsingly playable)
+            return beatmapInfo.Ruleset.ShortName == "osu";
+        }
+
+        public bool TryParseCustomKeywordCriteria(string key, Operator op, string value)
+        {
+            return false;
+        }
+
+        public bool FilterMayChangeFromMods(ValueChangedEvent<IReadOnlyList<Mod>> mods)
+        {
+            return false;
+        }
+    }
+}

osu.Game.Rulesets.Osu/OsuRuleset.cs

@@ -17,6 +17,7 @@
 using osu.Game.Rulesets.Configuration;
 using osu.Game.Rulesets.Difficulty;
 using osu.Game.Rulesets.Edit;
+using osu.Game.Rulesets.Filter;
 using osu.Game.Rulesets.Mods;
 using osu.Game.Rulesets.Osu.Beatmaps;
 using osu.Game.Rulesets.Osu.Configuration;
@@ -56,6 +57,8 @@ public class OsuRuleset : Ruleset, ILegacyRuleset
 
         public override IBeatmapProcessor CreateBeatmapProcessor(IBeatmap beatmap) => new OsuBeatmapProcessor(beatmap);
 
+        public override IRulesetFilterCriteria CreateRulesetFilterCriteria() => new OsuFilterCriteria();
+
         public const string SHORT_NAME = "osu";
 
         public override string RulesetAPIVersionSupported => CURRENT_RULESET_API_VERSION;

osu.Game.Rulesets.Taiko/TaikoFilterCriteria.cs

@@ -0,0 +1,37 @@
+// Copyright (c) ppy Pty Ltd <[email protected]>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using System.Collections.Generic;
+using osu.Framework.Bindables;
+using osu.Game.Beatmaps;
+using osu.Game.Rulesets.Filter;
+using osu.Game.Rulesets.Mods;
+using osu.Game.Screens.Select;
+using osu.Game.Screens.Select.Filter;
+
+namespace osu.Game.Rulesets.Taiko
+{
+    public class TaikoFilterCriteria : IRulesetFilterCriteria
+    {
+        public bool Matches(BeatmapInfo beatmapInfo, FilterCriteria criteria)
+        {
+            // Taiko is very well convertible, surprisingly even with CtB.
+            // However, Mania conversion currently still needs some work since
+            // the converted maps often have way too many spinners.
+            return beatmapInfo.Ruleset.ShortName == "taiko"
+                || (criteria.AllowConvertedBeatmaps && (
+                    beatmapInfo.Ruleset.ShortName == "osu" ||
+                    beatmapInfo.Ruleset.ShortName == "fruits"));
+        }
+
+        public bool TryParseCustomKeywordCriteria(string key, Operator op, string value)
+        {
+            return false;
+        }
+
+        public bool FilterMayChangeFromMods(ValueChangedEvent<IReadOnlyList<Mod>> mods)
+        {
+            return false;
+        }
+    }
+}

osu.Game.Rulesets.Taiko/TaikoRuleset.cs

@@ -37,6 +37,7 @@
 using osu.Game.Rulesets.Taiko.Configuration;
 using osu.Game.Rulesets.Taiko.Edit.Setup;
 using osu.Game.Screens.Edit.Setup;
+using osu.Game.Rulesets.Filter;
 
 namespace osu.Game.Rulesets.Taiko
 {
@@ -64,6 +65,8 @@ public class TaikoRuleset : Ruleset, ILegacyRuleset
             return null;
         }
 
+        public override IRulesetFilterCriteria CreateRulesetFilterCriteria() => new TaikoFilterCriteria();
+
         public const string SHORT_NAME = "taiko";
 
         public override string RulesetAPIVersionSupported => CURRENT_RULESET_API_VERSION;

osu.Game/Screens/Select/Carousel/CarouselBeatmap.cs

@@ -31,18 +31,13 @@ public override void Filter(FilterCriteria criteria)
 
         private bool checkMatch(FilterCriteria criteria)
         {
-            bool match =
-                criteria.Ruleset == null ||
-                BeatmapInfo.Ruleset.ShortName == criteria.Ruleset.ShortName ||
-                (BeatmapInfo.Ruleset.OnlineID == 0 && criteria.Ruleset.OnlineID != 0 && criteria.AllowConvertedBeatmaps);
-
             if (BeatmapInfo.BeatmapSet?.Equals(criteria.SelectedBeatmapSet) == true)
             {
-                // only check ruleset equality or convertability for selected beatmap
-                return match;
+                // only check convertability for selected beatmap
+                return true;
             }
 
-            if (!match) return false;
+            bool match = true;
 
             if (criteria.SearchTerms.Length > 0)
             {