Skip to content

vega-embed relies on fast-json-patch which does not get hoisted properly by parcel #346

Open
@marshallpete

Description

@marshallpete

Provide a general summary of the issue here

vega-embed has a dependency on fast-json-patch which does not currently get hoisted correctly in parcel. vega-embed also has vega-lite as a required dependency which is almost a 10MB package that we never use.

🤔 Expected Behavior?

react-spectrum-charts will work in parcel production builds without special package.json setup.

😯 Current Behavior

parcel apps need to add an alias to their package.json that points to the index.js file for fast-json-patch instead of the index.mjs file.

💁 Possible Solution

Remove our dependency on vega-embed by reimplementing the necessary parts in react-spectrum-charts

🔦 Context

No response

🖥️ Steps to Reproduce

  1. Create a simple parcel app
  2. Add fast-json-patch
  3. Serve with hoisting enabled

Version

v1.10.1

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Mac OS 14.5

🧢 Your Company/Team

Adobe

🕷 Tracking Issue

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions