Skip to content

Replace init_network() part of interface #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrederikHeber opened this issue Jun 29, 2018 · 0 comments
Open

Replace init_network() part of interface #39

FrederikHeber opened this issue Jun 29, 2018 · 0 comments
Milestone

Comments

@FrederikHeber
Copy link
Collaborator

init_network() is quite clumsy and the setup parameter is ont very intuitive.

Maybe we could change this into an initial init_network() (which might be hidden in some general init() function or even in the constructor of the class) and then have functions like add_feature("sample") that would add a specific feature to the computational graph by adding its nodes. This could be explained by the extra cost that some features (hessians) incur on construction.

Functions in the simulations interface should also check whether these features are present and give appropriate error messages suggesting to add the respective feature.

@FrederikHeber FrederikHeber added this to the v0.9 milestone Jun 29, 2018
@FrederikHeber FrederikHeber modified the milestones: v0.9, v1.0 Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant