Skip to content

Commit f15923c

Browse files
committed
Updated windows build action docs
1 parent 27b4c85 commit f15923c

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

.github/workflows/linux.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Build Desktop App (Linux)
1+
name: Build Desktop App (Linux - deb)
22

33
on:
44
# push:
@@ -66,4 +66,4 @@ jobs:
6666
uses: actions/upload-artifact@v4
6767
with:
6868
name: linux
69-
path: dist/bundle/appimage/**/*
69+
path: dist/bundle/deb/**/*

.github/workflows/windows.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
name: Build Desktop App (Windows)
22

33
on:
4-
# push:
5-
# branches:
6-
# - master
4+
push:
5+
branches:
6+
- master
77
# pull_request:
88
# branches:
99
# - master

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,11 @@ DATABASE_URL
173173
- To deploy the web app using Github Pages you have to choose in the repository settings under Pages the `gh-pages` branch. You should also set workflow permissions under the Actions settings to `Read and write permissions`.
174174
- Change the `base_path` in the `Dioxus.pages.toml` file to match the name of your repository.
175175
- Remember to deploy your api with `APP_URL` set to your Github Pages domain (e.g. `https://albbus-stack.github.io`) otherwise there will be CORS errors.
176-
- Configure the `.github/workflows/deploy-web.yaml` workflow to deploy on every push to the `main` branch or manually with the `workflow_dispatch` event.
176+
- Configure the `.github/workflows/deploy-web.yaml` workflow to deploy on every push to the `master` branch or manually with the `workflow_dispatch` event.
177177

178178
### Desktop
179179

180-
> Github actions for the Windows, Linux and MacOS platforms are not yet functioning since `dx bundle` fails with various errors.
180+
> Github actions for the Linux and MacOS platforms are not yet functioning since `dx bundle` fails with various errors.
181181
182-
- Currently `dx bundle` is being actively developed and is not yet ready for production use, so you should use `dx build` if bundling fails (this is not good since you need attach the `dist` folder to your release to include your assets).
182+
- For Windows you can configure the `.github/workflows/windows.yaml` workflow to build and upload the `.msi` installer in the action artifacts on every push to the `master` branch or manually with the `workflow_dispatch` event.
183+
- Currently `dx bundle` is being actively developed and is not yet ready for production use, so you should use `dx build` if bundling fails on other platforms (this is not good since you need attach the entire `dist` folder to your release build).

0 commit comments

Comments
 (0)