feat: new test: test_delete_instance_with_insufficient_funds

Author: 1yam

tests/unit/test_instance.py

@@ -8,6 +8,8 @@
 
 import pytest
 from aiohttp import InvalidURL
+from aleph.sdk.exceptions import InsufficientFundsError
+from aleph.sdk.types import TokenType
 from aleph_message.models import Chain, ItemHash
 from aleph_message.models.execution.base import Payment, PaymentType
 from aleph_message.models.execution.environment import (
@@ -16,6 +18,7 @@
     HypervisorType,
 )
 from multidict import CIMultiDict, CIMultiDictProxy
+from typer import Exit
 
 from aleph_client.commands import help_strings
 from aleph_client.commands.instance import (
@@ -556,11 +559,18 @@ async def test_delete_instance():
     mock_auth_client_class, mock_auth_client = create_mock_auth_client(mock_account)
     mock_fetch_vm_info = create_mock_fetch_vm_info()
     mock_vm_client_class, mock_vm_client = create_mock_vm_client()
+    mock_fetch_settings = AsyncMock(
+        return_value={
+            "community_wallet_timestamp": 900000,  # Before creation time
+            "community_wallet_address": "0xcommunity",
+        }
+    )
 
     @patch("aleph_client.commands.instance._load_account", mock_load_account)
     @patch("aleph_client.commands.instance.AuthenticatedAlephHttpClient", mock_auth_client_class)
     @patch("aleph_client.commands.instance.fetch_vm_info", mock_fetch_vm_info)
     @patch("aleph_client.commands.instance.VmClient", mock_vm_client_class)
+    @patch("aleph_client.commands.instance.fetch_settings", mock_fetch_settings)
     @patch.object(asyncio, "sleep", AsyncMock())
     async def delete_instance():
         print()  # For better display when pytest -v -s
@@ -573,6 +583,46 @@ async def delete_instance():
     await delete_instance()
 
 
+@pytest.mark.asyncio
+async def test_delete_instance_with_insufficient_funds():
+
+    mock_load_account = create_mock_load_account()
+    mock_account = mock_load_account.return_value
+
+    # Configure manage_flow to raise InsufficientFundsError
+    insufficient_funds_error = InsufficientFundsError(
+        token_type=TokenType.GAS, required_funds=10.0, available_funds=5.0
+    )
+    mock_account.manage_flow = AsyncMock(side_effect=insufficient_funds_error)
+
+    mock_auth_client_class, mock_auth_client = create_mock_auth_client(mock_account)
+    mock_fetch_vm_info = create_mock_fetch_vm_info()
+    mock_vm_client_class, mock_vm_client = create_mock_vm_client()
+    mock_fetch_settings = AsyncMock(
+        return_value={
+            "community_wallet_timestamp": 900000,  # Before creation time
+            "community_wallet_address": "0xcommunity",
+        }
+    )
+
+    @patch("aleph_client.commands.instance._load_account", mock_load_account)
+    @patch("aleph_client.commands.instance.AuthenticatedAlephHttpClient", mock_auth_client_class)
+    @patch("aleph_client.commands.instance.fetch_vm_info", mock_fetch_vm_info)
+    @patch("aleph_client.commands.instance.VmClient", mock_vm_client_class)
+    @patch("aleph_client.commands.instance.fetch_settings", mock_fetch_settings)
+    @patch.object(asyncio, "sleep", AsyncMock())
+    async def delete_instance_with_insufficient_funds():
+        print()  # For better display when pytest -v -s
+        with pytest.raises(Exit):  # We expect Exit to be raised
+            await delete(FAKE_VM_HASH)
+        mock_auth_client.get_message.assert_called_once()
+        mock_vm_client.erase_instance.assert_called_once()
+        mock_account.manage_flow.assert_called_once()  # First manage_flow call raises the error
+        mock_auth_client.forget.assert_not_called()  # This should not be called as we exit early
+
+    await delete_instance_with_insufficient_funds()
+
+
 @pytest.mark.asyncio
 async def test_reboot_instance():
     mock_load_account = create_mock_load_account()