Skip to content

Commit 6b6ec88

Browse files
committed
Fix: Improve garbage collection sessions to handle it individually.
1 parent 5b36122 commit 6b6ec88

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/aleph/services/storage/garbage_collector.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ async def collect(self, datetime: dt.datetime):
5252
files_to_delete = list(get_unpinned_files(session))
5353
LOGGER.info("Found %d files to delete", len(files_to_delete))
5454

55-
for file_to_delete in files_to_delete:
55+
for file_to_delete in files_to_delete:
56+
with self.session_factory() as session:
5657
try:
5758
file_hash = ItemHash(file_to_delete.hash)
5859
LOGGER.info("Deleting %s...", file_hash)
@@ -68,6 +69,7 @@ async def collect(self, datetime: dt.datetime):
6869
LOGGER.info("Deleted %s", file_hash)
6970
except Exception as err:
7071
LOGGER.error("Failed to delete file %s: %s", file_hash, str(err))
72+
session.rollback()
7173

7274

7375
async def garbage_collector_task(

0 commit comments

Comments
 (0)