Fix: Remove IPFS Garbage collection call and force the daemon to have it enabled.

Author: Andres D. Molins

deployment/docker-build/dev/docker-compose.yml

@@ -115,7 +115,7 @@ services:
 
   ipfs:
     restart: always
-    image: ipfs/kubo:v0.15.0
+    image: ipfs/kubo:v0.34.1
     ports:
       - "4001:4001"
       - "4001:4001/udp"
@@ -126,7 +126,7 @@ services:
       - IPFS_PROFILE=server
     networks:
       - pyaleph
-    command: ["daemon", "--enable-pubsub-experiment", "--migrate"]
+    command: ["daemon", "--enable-pubsub-experiment", "--enable-gc", "--migrate"]
 
 
 networks:

deployment/docker-build/docker-compose.yml

@@ -47,7 +47,7 @@ services:
 
   ipfs:
     restart: always
-    image: ipfs/kubo:v0.15.0
+    image: ipfs/kubo:v0.34.1
     ports:
       - "4001:4001"
       - "4001:4001/udp"
@@ -59,7 +59,7 @@ services:
       - IPFS_PROFILE=server
     networks:
       - pyaleph
-    command: ["daemon", "--enable-pubsub-experiment", "--migrate"]
+    command: ["daemon", "--enable-pubsub-experiment", "--enable-gc", "--migrate"]
 
   postgres:
     restart: always

deployment/samples/docker-compose/docker-compose.yml

@@ -105,7 +105,7 @@ services:
 
   ipfs:
     restart: always
-    image: ipfs/kubo:v0.15.0
+    image: ipfs/kubo:v0.34.1
     ports:
       - "4001:4001"
       - "4001:4001/udp"

deployment/samples/docker-monitoring/docker-compose.yml

@@ -107,7 +107,7 @@ services:
 
   ipfs:
     restart: always
-    image: ipfs/kubo:v0.15.0
+    image: ipfs/kubo:v0.34.1
     ports:
       - "4001:4001"
       - "4001:4001/udp"
@@ -118,7 +118,7 @@ services:
       - IPFS_PROFILE=server
     networks:
       - pyaleph
-    command: ["daemon", "--enable-pubsub-experiment", "--migrate"]
+    command: ["daemon", "--enable-pubsub-experiment", "--enable-gc", "--migrate"]
 
   prometheus:
     restart: always

src/aleph/db/accessors/messages.py

@@ -460,7 +460,9 @@ def ensure_serializable(obj):
 
         except Exception:
             # If any conversion fails, create a new dict with a message
-            serializable_details = {"error": "Details contained non-serializable values"}
+            serializable_details = {
+                "error": "Details contained non-serializable values"
+            }
 
     insert_rejected_message_stmt = insert(RejectedMessageDb).values(
         item_hash=item_hash,

src/aleph/services/storage/garbage_collector.py

@@ -3,7 +3,6 @@
 import logging
 
 from aioipfs import NotPinnedError
-from aioipfs.api import RepoAPI
 from aleph_message.models import ItemHash, ItemType
 from configmanager import Config
 
@@ -69,12 +68,6 @@ async def collect(self, datetime: dt.datetime):
 
                 LOGGER.info("Deleted %s", file_hash)
 
-            # After unpinned all files call the ipfs garbage collector
-            ipfs_client = self.storage_service.ipfs_service.ipfs_client
-            # Launch the IPFS garbage collector (`ipfs repo gc`)
-            async for _ in RepoAPI(driver=ipfs_client).gc():
-                pass
-
 
 async def garbage_collector_task(
     config: Config, garbage_collector: GarbageCollector
@@ -96,4 +89,6 @@ async def garbage_collector_task(
             await garbage_collector.collect(datetime=utc_now())
             LOGGER.info("Garbage collector ran successfully.")
         except Exception as err:
-            LOGGER.exception("An unexpected error occurred during garbage collection.", exc_info=err)
+            LOGGER.exception(
+                "An unexpected error occurred during garbage collection.", exc_info=err
+            )

src/aleph/types/message_status.py

@@ -90,7 +90,7 @@ def details(self) -> Optional[Dict[str, Any]]:
                 try:
                     # Test if the error is JSON serializable by attempting to convert to dict
                     # This will fail for custom objects
-                    if hasattr(err, '__dict__'):
+                    if hasattr(err, "__dict__"):
                         serializable_errors.append(str(err))
                     else:
                         serializable_errors.append(err)