Skip to content

Commit 72af00d

Browse files
authored
Merge pull request #1671 from algolia/fix/MAGE-1179-phpcs
MAGE-1179 3.14 release prep - Address phpcs complaint
2 parents 5f5e9ed + 7b0f345 commit 72af00d

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

Service/Product/MissingPriceIndexHandler.php

+6-7
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
use Magento\Framework\Indexer\IndexerInterface;
1111
use Magento\Framework\Indexer\IndexerRegistry;
1212
use Magento\Framework\Indexer\StateInterface;
13-
use Zend_Db_Select;
1413

1514
class MissingPriceIndexHandler
1615
{
@@ -120,7 +119,7 @@ protected function getProductIdsFromCollection(ProductCollection $collection): a
120119

121120
$select = clone $collection->getSelect();
122121
try {
123-
$joins = $select->getPart(Zend_Db_Select::FROM);
122+
$joins = $select->getPart(Select::FROM);
124123
} catch (\Zend_Db_Select_Exception $e) {
125124
$this->logger->error("Unable to build query for missing product prices: " . $e->getMessage());
126125
return [];
@@ -142,20 +141,20 @@ protected function getProductIdsFromCollection(ProductCollection $collection): a
142141
protected function expandPricingJoin(array &$joins, string $priceIndexJoin): void
143142
{
144143
$modifyJoin = &$joins[$priceIndexJoin];
145-
$modifyJoin['joinType'] = Zend_Db_Select::LEFT_JOIN;
144+
$modifyJoin['joinType'] = Select::LEFT_JOIN;
146145
}
147146

148147
protected function rebuildJoins(Select $select, array $joins): void
149148
{
150-
$select->reset(Zend_Db_Select::COLUMNS);
151-
$select->reset(Zend_Db_Select::FROM);
149+
$select->reset(Select::COLUMNS);
150+
$select->reset(Select::FROM);
152151
foreach ($joins as $alias => $joinData) {
153-
if ($joinData['joinType'] === Zend_Db_Select::FROM) {
152+
if ($joinData['joinType'] === Select::FROM) {
154153
$select->from(
155154
[$alias => $joinData['tableName']],
156155
'entity_id'
157156
);
158-
} elseif ($joinData['joinType'] === Zend_Db_Select::LEFT_JOIN) {
157+
} elseif ($joinData['joinType'] === Select::LEFT_JOIN) {
159158
$select->joinLeft(
160159
[$alias => $joinData['tableName']],
161160
$joinData['joinCondition'],

0 commit comments

Comments
 (0)