fixed top languages missing bug #536
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izdrail
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bug #535 where the top languages were not correctly sorted.
- Updated the sorting logic in make_list to sort the entire data set before slicing
- Ensured that the highest percentages are accurately captured
Comments suppressed due to low confidence (1)
sources/graphics_list_formatter.py:73
- The updated line now sorts the entire data set before slicing, which fixes the bug where only a subset was sorted; please confirm this behavior meets the intended design for displaying the top languages.
top_data = sorted(data, key=lambda record: record[2], reverse=True)[:top_num] if sort else data[:top_num]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #535