Skip to content

Commit d12ce37

Browse files
committed
fix build errors
1 parent bf89f4b commit d12ce37

File tree

2 files changed

+29
-32
lines changed

2 files changed

+29
-32
lines changed

example_structured_logging_test.go

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@ package gocql_test
2020

2121
import (
2222
"context"
23-
"fmt"
2423
"log"
2524
"os"
2625

27-
gocql "github.com/apache/cassandra-gocql-driver/v2"
28-
"github.com/apache/cassandra-gocql-driver/v2/gocqlzap"
29-
"github.com/apache/cassandra-gocql-driver/v2/gocqlzerolog"
3026
"github.com/rs/zerolog"
3127
"go.uber.org/zap"
3228
"go.uber.org/zap/zapcore"
29+
30+
gocql "github.com/apache/cassandra-gocql-driver/v2"
31+
"github.com/apache/cassandra-gocql-driver/v2/gocqlzap"
32+
"github.com/apache/cassandra-gocql-driver/v2/gocqlzerolog"
3333
)
3434

3535
// Example_structuredLogging demonstrates the new structured logging features
@@ -51,7 +51,7 @@ func Example_structuredLogging() {
5151
config := zap.NewProductionConfig()
5252
config.EncoderConfig.TimeKey = "timestamp"
5353
config.EncoderConfig.EncodeTime = zapcore.ISO8601TimeEncoder // Human-readable timestamp format
54-
54+
5555
zapLogger, err := config.Build()
5656
if err != nil {
5757
log.Fatal(err)
@@ -60,7 +60,7 @@ func Example_structuredLogging() {
6060

6161
// Create base logger with service identifier
6262
baseLogger := zapLogger.With(zap.String("service", "gocql-app"))
63-
63+
6464
// Create application and driver loggers with component identifiers
6565
appLogger := baseLogger.With(zap.String("component", "app"))
6666
driverLogger := baseLogger.With(zap.String("component", "gocql-driver"))
@@ -75,7 +75,7 @@ func Example_structuredLogging() {
7575
zapCluster := gocql.NewCluster("localhost:9042")
7676
zapCluster.Keyspace = "example"
7777
zapCluster.Logger = gocqlZapLogger
78-
78+
7979
zapSession, err := zapCluster.CreateSession()
8080
if err != nil {
8181
appLogger.Fatal("Failed to create session", zap.Error(err))
@@ -104,7 +104,7 @@ func Example_structuredLogging() {
104104
iter := zapSession.Query("SELECT id, value FROM example.log_demo WHERE id = ?").
105105
Bind(1).
106106
IterContext(ctx)
107-
107+
108108
if iter.Scan(&id, &value) {
109109
// Successfully scanned the row
110110
}
@@ -122,20 +122,20 @@ func Example_structuredLogging() {
122122
// Example 2: Using Zerolog integration
123123
// Create a production Zerolog logger with structured JSON output
124124
// Production config includes timestamps, service info, and appropriate log level
125-
baseLogger := zerolog.New(os.Stdout).
125+
baseZerologLogger := zerolog.New(os.Stdout).
126126
Level(zerolog.InfoLevel).
127127
With().
128128
Timestamp().
129129
Str("service", "gocql-app").
130130
Logger()
131131

132132
// Create application logger with component identifier
133-
appZerologLogger := baseLogger.With().
133+
appZerologLogger := baseZerologLogger.With().
134134
Str("component", "app").
135135
Logger()
136136

137137
// Create driver logger with component identifier
138-
driverZerologLogger := baseLogger.With().
138+
driverZerologLogger := baseZerologLogger.With().
139139
Str("component", "gocql-driver").
140140
Logger()
141141

@@ -145,12 +145,12 @@ func Example_structuredLogging() {
145145
Msg("Starting Zerolog structured logging example")
146146

147147
// Create gocql logger from driver logger
148-
gocqlZerologLogger := gocqlzerolog.Wrap(&driverZerologLogger)
148+
gocqlZerologLogger := gocqlzerolog.NewUnnamedZerologLogger(driverZerologLogger)
149149

150150
zerologCluster := gocql.NewCluster("localhost:9042")
151151
zerologCluster.Keyspace = "example"
152152
zerologCluster.Logger = gocqlZerologLogger
153-
153+
154154
zerologSession, err := zerologCluster.CreateSession()
155155
if err != nil {
156156
appZerologLogger.Fatal().Err(err).Msg("Failed to create session")
@@ -179,7 +179,7 @@ func Example_structuredLogging() {
179179
iter = zerologSession.Query("SELECT id, value FROM example.log_demo WHERE id = ?").
180180
Bind(2).
181181
IterContext(ctx)
182-
182+
183183
if iter.Scan(&id, &value) {
184184
// Successfully scanned the row
185185
}
@@ -195,8 +195,6 @@ func Example_structuredLogging() {
195195
Str("record_value", value).
196196
Msg("Database operation completed successfully")
197197

198-
199-
200198
// Example 1 - Zap structured logging output (JSON format):
201199
// {"level":"info","timestamp":"2021-12-31T12:00:00.000Z","service":"gocql-app","component":"app","msg":"Starting Zap structured logging example","example":"structured_logging","logger_type":"zap"}
202200
// {"level":"info","timestamp":"2021-12-31T12:00:00.100Z","service":"gocql-app","component":"gocql-driver","msg":"Discovered protocol version.","protocol_version":4}
@@ -219,4 +217,3 @@ func Example_structuredLogging() {
219217
// {"level":"info","service":"gocql-app","component":"app","time":"2021-12-31T12:00:12Z","operation":"select","record_id":2,"message":"Querying data from database"}
220218
// {"level":"info","service":"gocql-app","component":"app","time":"2021-12-31T12:00:13Z","operation":"select","record_id":2,"record_value":"zerolog logging demo","message":"Database operation completed successfully"}
221219
}
222-

example_vector_test.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ func Example_vector() {
3434
/* The example assumes the following CQL was used to setup the keyspace:
3535
create keyspace example with replication = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 };
3636
create table example.vectors(
37-
id int,
38-
item_name text,
39-
embedding vector<float, 5>,
37+
id int,
38+
item_name text,
39+
embedding vector<float, 5>,
4040
PRIMARY KEY(id)
4141
);
4242
-- Create SAI index for vector search (required for ANN)
@@ -75,9 +75,9 @@ func Example_vector() {
7575
// Insert sample vectors representing different items
7676
// These could be embeddings from ML models for products, documents, etc.
7777
vectorData := []struct {
78-
id int
79-
name string
80-
vector []float32
78+
id int
79+
name string
80+
vector []float32
8181
}{
8282
{1, "apple", []float32{0.8, 0.2, 0.1, 0.9, 0.3}},
8383
{2, "orange", []float32{0.7, 0.3, 0.2, 0.8, 0.4}},
@@ -118,7 +118,7 @@ func Example_vector() {
118118
var id int
119119
var itemName string
120120
var embedding []float32
121-
121+
122122
if !iter.Scan(&id, &itemName, &embedding) {
123123
break
124124
}
@@ -147,7 +147,7 @@ func Example_vector() {
147147
var id int
148148
var itemName string
149149
var embedding []float32
150-
150+
151151
err = scanner.Scan(&id, &itemName, &embedding)
152152
if err != nil {
153153
log.Fatal(err)
@@ -165,10 +165,10 @@ func Example_vector() {
165165
var id int
166166
var itemName string
167167
var embedding []float32
168-
err = session.Query("SELECT id, item_name, embedding FROM example.vectors WHERE id = ?", 1).
169-
ScanContext(ctx, &id, &itemName, &embedding)
170-
if err != nil {
171-
log.Fatal(err)
168+
iter = session.Query("SELECT id, item_name, embedding FROM example.vectors WHERE id = ?", 1).
169+
IterContext(ctx)
170+
if !iter.Scan(&id, &itemName, &embedding) {
171+
log.Fatal(iter.Close())
172172
}
173173
fmt.Printf(" %s (ID: %d) - Vector: %v\n", itemName, id, embedding)
174174

@@ -181,7 +181,7 @@ func Example_vector() {
181181
var id int
182182
var itemName string
183183
var embedding []float32
184-
184+
185185
if !allVectors.Scan(&id, &itemName, &embedding) {
186186
break
187187
}
@@ -195,9 +195,9 @@ func Example_vector() {
195195
// Creating SAI index for vector search...
196196
// Inserting sample vectors...
197197
// Searching for vectors similar to: [0.8 0.2 0.1 0.9 0.3]
198-
//
198+
//
199199
// Top 3 most similar items (using ANN search):
200200
// apple (ID: 1) - Vector: [0.8 0.2 0.1 0.9 0.3]
201201
// strawberry (ID: 6) - Vector: [0.8 0.3 0.2 0.9 0.4]
202202
// orange (ID: 2) - Vector: [0.7 0.3 0.2 0.8 0.4]
203-
}
203+
}

0 commit comments

Comments
 (0)