Skip to content

Commit 86375a0

Browse files
committed
Removed empty ComponentRegistry.shutdown() method
Removed m_componentActor parameter from ComponentRegistry.missingServicePresent()
1 parent d76321f commit 86375a0

File tree

5 files changed

+5
-10
lines changed

5 files changed

+5
-10
lines changed

scr/src/main/java/org/apache/felix/scr/impl/Activator.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,6 @@ public void doStop() throws Exception
422422
// dispose component registry
423423
if ( m_componentRegistry != null )
424424
{
425-
m_componentRegistry.shutdown();
426425
m_componentRegistry = null;
427426
}
428427

scr/src/main/java/org/apache/felix/scr/impl/BundleComponentActivator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -763,7 +763,7 @@ public <T> void leaveCreate(ServiceReference<T> serviceReference)
763763
@Override
764764
public <T> void missingServicePresent(ServiceReference<T> serviceReference)
765765
{
766-
m_componentRegistry.missingServicePresent( serviceReference, m_componentActor );
766+
m_componentRegistry.missingServicePresent( serviceReference );
767767
}
768768

769769
@Override

scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ public <T> void leaveCreate(final ServiceReference<T> serviceReference)
562562
* @param serviceReference
563563
* @param actor
564564
*/
565-
public synchronized <T> void missingServicePresent( final ServiceReference<T> serviceReference, ScheduledExecutorService actor )
565+
public synchronized <T> void missingServicePresent( final ServiceReference<T> serviceReference )
566566
{
567567
final List<Entry<?, ?>> dependencyManagers = m_missingDependencies.remove( serviceReference );
568568
if ( dependencyManagers != null )
@@ -592,7 +592,7 @@ public String toString()
592592
} ;
593593
m_logger.log(Level.DEBUG,
594594
"Scheduling runnable {0} asynchronously", null, runnable);
595-
actor.submit( runnable );
595+
m_componentActor.submit( runnable );
596596
}
597597
}
598598

@@ -756,8 +756,4 @@ public void run()
756756
}
757757
}
758758
}
759-
760-
public void shutdown() {
761-
762-
}
763759
}

scr/src/test/java/org/apache/felix/scr/integration/ComponentTestBase.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
import javax.inject.Inject;
5656

5757
import org.apache.felix.scr.impl.ComponentCommands;
58+
import org.apache.felix.scr.impl.manager.ScrConfiguration;
5859
import org.apache.felix.scr.integration.components.SimpleComponent;
5960
import org.apache.felix.service.command.Converter;
6061
import org.junit.After;
@@ -141,7 +142,7 @@ public abstract class ComponentTestBase
141142

142143
protected static final String PROP_NAME_FACTORY = ComponentTestBase.PROP_NAME + ".factory";
143144

144-
protected static long DS_SERVICE_CHANGECOUNT_TIMEOUT = 5000;
145+
protected static long DS_SERVICE_CHANGECOUNT_TIMEOUT = ScrConfiguration.DEFAULT_SERVICE_CHANGECOUNT_TIMEOUT_MILLISECONDS;
145146

146147
static
147148
{

scr/src/test/java/org/apache/felix/scr/integration/Felix6778Test.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ public class Felix6778Test extends ComponentTestBase implements ServiceListener
4444
{
4545
descriptorFile = "/integration_test_simple_components.xml";
4646
DS_SERVICE_CHANGECOUNT_TIMEOUT = 1000;
47-
// paxRunnerVmOption = "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=localhost:5005";
4847
}
4948

5049
class RecordedScrChangeCount

0 commit comments

Comments
 (0)