Implement bulk adding methods for dynamic pruning. (#14365)

Author: gf2121

lucene/CHANGES.txt

@@ -185,7 +185,9 @@ Optimizations
 
 * GITHUB#14301: Avoid unnecessary evaluations and skipping documents. (hanbj)
 
-# GITHUB#14203: Decode doc ids in BKD leaves with auto-vectorized loops when using DEFAULT_MAX_POINTS_IN_LEAF_NODE. (Guo Feng)
+* GITHUB#14203: Decode doc ids in BKD leaves with auto-vectorized loops when using DEFAULT_MAX_POINTS_IN_LEAF_NODE. (Guo Feng)
+
+* GITHUB#14176: Avoid the per-doc virtual call when building competitive iterator for dynamic pruning. (Guo Feng)
 
 # GITHUB#14361: Introduce new encoding of BPV 21 for DocIdsWriter used in BKD Tree. (Aniketh Jain, Guo Feng)
 

lucene/core/src/java/org/apache/lucene/index/PointValues.java

@@ -291,6 +291,8 @@ public interface IntersectVisitor {
     /**
      * Similar to {@link IntersectVisitor#visit(int)}, but a bulk visit and implementations may have
      * their optimizations.
+     *
+     * <p>It is guaranteed that the given iterator is not positioned;
      */
     default void visit(DocIdSetIterator iterator) throws IOException {
       int docID;

lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java

@@ -31,6 +31,7 @@
 import org.apache.lucene.search.Scorer;
 import org.apache.lucene.util.DocIdSetBuilder;
 import org.apache.lucene.util.FixedBitSet;
+import org.apache.lucene.util.IntsRef;
 
 /**
  * Abstract numeric comparator for comparing numeric values. This comparator provides a skipping
@@ -251,6 +252,19 @@ public void visit(int docID, byte[] packedValue) {
               }
             }
 
+            @Override
+            public void visit(DocIdSetIterator iterator) throws IOException {
+              if (iterator.advance(maxDocVisited + 1) != DocIdSetIterator.NO_MORE_DOCS) {
+                adder.add(iterator.docID());
+                adder.add(iterator);
+              }
+            }
+
+            @Override
+            public void visit(IntsRef ref) {
+              adder.add(ref, maxDocVisited + 1);
+            }
+
             @Override
             public PointValues.Relation compare(byte[] minPackedValue, byte[] maxPackedValue) {
               long min = sortableBytesToLong(minPackedValue);

lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java

@@ -47,6 +47,8 @@ public sealed interface BulkAdder permits FixedBitSetAdder, BufferAdder {
     void add(IntsRef docs);
 
     void add(DocIdSetIterator iterator) throws IOException;
+
+    void add(IntsRef docs, int docLowerBoundInclusive);
   }
 
   private record FixedBitSetAdder(FixedBitSet bitSet) implements BulkAdder {
@@ -65,7 +67,18 @@ public void add(IntsRef docs) {
 
     @Override
     public void add(DocIdSetIterator iterator) throws IOException {
-      bitSet.or(iterator);
+      iterator.nextDoc();
+      iterator.intoBitSet(DocIdSetIterator.NO_MORE_DOCS, bitSet, 0);
+    }
+
+    @Override
+    public void add(IntsRef docs, int docLowerBoundInclusive) {
+      for (int i = docs.offset, to = docs.offset + docs.length; i < to; i++) {
+        int doc = docs.ints[i];
+        if (doc >= docLowerBoundInclusive) {
+          bitSet.set(doc);
+        }
+      }
     }
   }
 
@@ -104,6 +117,18 @@ public void add(DocIdSetIterator iterator) throws IOException {
         add(docID);
       }
     }
+
+    @Override
+    public void add(IntsRef docs, int docLowerBoundInclusive) {
+      int index = buffer.length;
+      for (int i = docs.offset, to = docs.offset + docs.length; i < to; i++) {
+        int doc = docs.ints[i];
+        if (doc >= docLowerBoundInclusive) {
+          buffer.array[index++] = doc;
+        }
+      }
+      buffer.length = index;
+    }
   }
 
   private final int maxDoc;