Replace oal.search.Score with oal.search.SimpleScorable. #14852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`oal.search.SimpleScorable` is a superset of `oal.search.Score`, so we can remove the latter in favor of the former. I also removed a custom `DocAndScore` class which a copy of `SimpleScorable`.
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
jpountz
added
the
skip-changelog
gf2121
approved these changes
Jun 26, 2025
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
jpountz
added a commit
that referenced
this pull request
Jun 30, 2025
`oal.search.SimpleScorable` is a superset of `oal.search.Score`, so we can remove the latter in favor of the former. I also removed a custom `DocAndScore` class which a copy of `SimpleScorable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oal.search.SimpleScorableis a superset ofoal.search.Score, so we can remove the latter in favor of the former. I also removed a customDocAndScoreclass which a copy ofSimpleScorable.