Skip to content

Change StringBuilder.Remove to J2N appropiate methods #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nikcio opened this issue Oct 15, 2022 · 0 comments · May be fixed by #1132
Open

Change StringBuilder.Remove to J2N appropiate methods #664

nikcio opened this issue Oct 15, 2022 · 0 comments · May be fixed by #1132
Assignees
@paulirwin
Labels
is:enhancement New feature or request pri:normal
Milestone
4.8.0-beta00018

Comments

@nikcio
Copy link
Contributor

nikcio commented Oct 15, 2022

Originally discussed in #654

TLDR:
StringBuilder.Remove should be replaced with StringBuilder.Delete (From J2N)
StringBuilder.Remove followed by StringBuilder.Insert replaced with StringBuilder.Replace (From J2N)

Be aware that the J2N methods uses .NET semantics startIndex and length where as the Java source uses startIndex and endIndex which means the parameters doesn't match 1:1. See #654 for more information.

Note: We should be checking against the Lucene 4.8.0 or 4.8.1 source to be sure that the methods match the original Java code.

Lucene 4.8.0 source can be found here: https://github.com/apache/lucene-solr/tree/releases/lucene-solr/4.8.0/lucene
Lucene 4.8.1 source can be found here: https://github.com/apache/lucene-solr/tree/releases/lucene-solr/4.8.1/lucene
@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone good-first-issue Good for newcomers is:enhancement New feature or request hacktoberfest-accepted labels Oct 15, 2022
@paulirwin paulirwin added this to the 4.8.0 milestone Oct 28, 2024
@paulirwin paulirwin modified the milestones: 4.8.0, 4.8.0-beta00018 Nov 18, 2024
@paulirwin paulirwin self-assigned this Mar 3, 2025
paulirwin added a commit to paulirwin/lucene.net that referenced this issue Mar 3, 2025
@paulirwin
Use J2N methods instead of StringBuilder.Remove, apache#664
a5700ef
@paulirwin paulirwin removed up-for-grabs This issue is open to be worked on by anyone hacktoberfest-accepted good-first-issue Good for newcomers labels Mar 3, 2025
paulirwin added a commit to paulirwin/lucene.net that referenced this issue Mar 3, 2025
@paulirwin
Use J2N methods instead of StringBuilder.Remove, apache#664
7b84524
@paulirwin paulirwin linked a pull request Mar 3, 2025 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulirwin paulirwin

Labels
is:enhancement New feature or request pri:normal
Projects
None yet
Milestone
4.8.0-beta00018
Development

Successfully merging a pull request may close this issue.

Use J2N methods instead of StringBuilder.Remove, #664 paulirwin/lucene.net
3 participants
@NightOwl888 @paulirwin @nikcio