-
-
Notifications
You must be signed in to change notification settings - Fork 134
Open
Description
API Platform version(s) affected: "@api-platform/admin": "^4.0.7"
What you were expecting:
showing proper loading message
What happened instead:
it shows ra.loading.page
Steps to reproduce:
create new project and working with HydraAdmin component from "@api-platform/admin"
Related code:
// in src/components/AdminApp.tsx
import { Resource, DataProvider, CustomRoutes, Loading } from 'react-admin'
import { hydraDataProvider, fetchHydra } from '@api-platform/admin'
import { HydraAdmin } from '@api-platform/admin'
...
const AdminApp = () => {
const dataProvider = useRef<DataProvider>()
dataProvider.current = hydraDataProvider({
entrypoint: ENTRYPOINT,
httpClient: (url: URL, options = {}) =>
fetchHydra(url, {
...options,
headers: {
Authorization: `Bearer ${localStorage.getItem('token')}`,
},
}),
apiDocumentationParser: apiDocumentationParser(localStorage.getItem('token')),
})
return (
<HydraAdmin
authProvider={authProvider}
loginPage={LoginPage}
dataProvider={dataProvider.current}
entrypoint={ENTRYPOINT}
loading={() => <Loading loadingPrimary="loading ..." loadingSecondary="please wait" />}
layout={Layout}
>
...
</HydraAdmin>
)
}
export default AdminApp
Environment
- React-admin version: 5.8.3
- Last version that did not exhibit the issue (if applicable): 4.7.4
- React version: 19.1.0
- Browser: chrome
- Stack trace (in case of a JS error): nan
Possible Solution
marmelab/react-admin#10813 (comment)
as mentioned by react admin maintainer : It seems the loading prop isn't propagated correctly: https://github.com/api-platform/admin/blob/main/src/core/AdminResourcesGuesser.tsx#L61C3-L61C10
Metadata
Metadata
Assignees
Labels
No labels