fix(test): remove SerializerAwareProvider mechanism and related compiler pass

Fixes phpstan error ignored in the config.

Author: vinceAmstoutz

phpstan.neon.dist

@@ -104,12 +104,6 @@ parameters:
 				- src/Serializer/AbstractConstraintViolationListNormalizer.php
 				- src/Symfony/Validator/Serializer/ValidationExceptionNormalizer.php
 
-		# See https://github.com/phpstan/phpstan-symfony/issues/27
-		-
-			message: '#^Service "[^"]+" is private.$#'
-			path: src
-
-
 		# Allow extra assertions in tests: https://github.com/phpstan/phpstan-strict-rules/issues/130
 		- '#^Call to (static )?method PHPUnit\\Framework\\Assert::.* will always evaluate to true\.$#'
 

src/State/SerializerAwareProviderInterface.php

@@ -16,7 +16,6 @@
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\AttributeFilterPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\AttributeResourcePass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\AuthenticatorManagerPass;
-use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\DataProviderPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\ElasticsearchClientPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\FilterPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\GraphQlResolverPass;
@@ -43,7 +42,6 @@ public function build(ContainerBuilder $container): void
     {
         parent::build($container);
 
-        $container->addCompilerPass(new DataProviderPass());
         // Run the compiler pass before the {@see ResolveInstanceofConditionalsPass} to allow autoconfiguration of generated filter definitions.
         $container->addCompilerPass(new AttributeFilterPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 101);
         $container->addCompilerPass(new AttributeResourcePass());

src/State/SerializerAwareProviderTrait.php

@@ -15,15 +15,26 @@
 
 use ApiPlatform\Metadata\Operation;
 use ApiPlatform\State\ProviderInterface;
-use ApiPlatform\State\SerializerAwareProviderInterface;
-use ApiPlatform\State\SerializerAwareProviderTrait;
+use Psr\Container\ContainerInterface;
+use Symfony\Component\Serializer\SerializerInterface;
+use Symfony\Contracts\Service\ServiceSubscriberInterface;
 
 /**
  * @author Vincent Chalamon <[email protected]>
  */
-class SerializableProvider implements ProviderInterface, SerializerAwareProviderInterface
+readonly class SerializableProvider implements ProviderInterface, ServiceSubscriberInterface
 {
-    use SerializerAwareProviderTrait;
+    public function __construct(private ContainerInterface $container)
+    {
+    }
+
+    /**
+     * @return array<string, string>
+     */
+    public static function getSubscribedServices(): array
+    {
+        return ['serializer' => SerializerInterface::class];
+    }
 
     /**
      * {@inheritDoc}
@@ -39,4 +50,13 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
 JSON
             , $operation->getClass(), 'json');
     }
+
+    private function getSerializer(): SerializerInterface
+    {
+        if (!$this->container->has('serializer')) {
+            throw new \LogicException('The serializer service is not available. Did you forget to install symfony/serializer?');
+        }
+
+        return $this->container->get('serializer');
+    }
 }

src/Symfony/Bundle/ApiPlatformBundle.php

@@ -138,6 +138,9 @@ services:
         class: 'ApiPlatform\Tests\Fixtures\TestBundle\State\SerializableProvider'
         tags:
             - name: 'api_platform.state_provider'
+        arguments:
+            - !service_locator
+                serializer: '@Symfony\Component\Serializer\SerializerInterface'
 
     ApiPlatform\Tests\Fixtures\TestBundle\State\FakeProvider:
         class: 'ApiPlatform\Tests\Fixtures\TestBundle\State\FakeProvider'

src/Symfony/Bundle/DependencyInjection/Compiler/DataProviderPass.php

@@ -17,7 +17,6 @@
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\AttributeFilterPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\AttributeResourcePass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\AuthenticatorManagerPass;
-use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\DataProviderPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\ElasticsearchClientPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\FilterPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\GraphQlResolverPass;
@@ -42,7 +41,6 @@ class ApiPlatformBundleTest extends TestCase
     public function testBuild(): void
     {
         $containerProphecy = $this->prophesize(ContainerBuilder::class);
-        $containerProphecy->addCompilerPass(Argument::type(DataProviderPass::class))->willReturn($containerProphecy->reveal())->shouldBeCalled();
         $containerProphecy->addCompilerPass(Argument::type(AttributeFilterPass::class), PassConfig::TYPE_BEFORE_OPTIMIZATION, 101)->willReturn($containerProphecy->reveal())->shouldBeCalled();
         $containerProphecy->addCompilerPass(Argument::type(AttributeResourcePass::class))->shouldBeCalled()->willReturn($containerProphecy->reveal())->shouldBeCalled();
         $containerProphecy->addCompilerPass(Argument::type(FilterPass::class))->willReturn($containerProphecy->reveal())->shouldBeCalled();