fix: decode OpenLibrary author response before accessing fields (#519)

yaposmihayus · web-flow · commit c156ecfe140d · 2025-04-18T09:24:35.000+02:00
diff --git a/api/src/BookRepository/OpenLibraryBookRepository.php b/api/src/BookRepository/OpenLibraryBookRepository.php
@@ -36,7 +36,8 @@ public function find(string $url): ?Book
 
         $book->author = null;
         if (isset($data['authors'][0]['key'])) {
-            $author = $this->openLibraryClient->request('GET', $data['authors'][0]['key'] . '.json', $options);
+            $authorResponse = $this->openLibraryClient->request('GET', $data['authors'][0]['key'] . '.json', $options);
+            $author = $this->decoder->decode($authorResponse->getContent(), 'json');
             if (isset($author['name'])) {
                 $book->author = $author['name'];
             }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,8 @@ public function find(string $url): ?Book`
`36`	`36`
`37`	`37`	`$book->author = null;`
`38`	`38`	`if (isset($data['authors'][0]['key'])) {`
`39`		`- $author = $this->openLibraryClient->request('GET', $data['authors'][0]['key'] . '.json', $options);`
	`39`	`+ $authorResponse = $this->openLibraryClient->request('GET', $data['authors'][0]['key'] . '.json', $options);`
	`40`	`+ $author = $this->decoder->decode($authorResponse->getContent(), 'json');`
`40`	`41`	`if (isset($author['name'])) {`
`41`	`42`	`$book->author = $author['name'];`
`42`	`43`	`}`