-
Notifications
You must be signed in to change notification settings - Fork 16
Camera flashing and 'freezes' on iPhone X #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @chrisedington! Thanks for the info. Do you have any chance to provide logs? |
@AndrewShapovalov can try - what source or kind of logs would you be looking for? |
Debug logs from Xcode (Debug area) while the problem happens. |
Hi @chrisedington! Some update from my side - tried to reproduce the bug on iPhone X with iOS version |
I have same problem. I write Test Environment and Error log below. Test Env.
Device: Debug Log:
|
Hi @wizfinder, thanks for the report! Is the same or any other error in the |
Hi @chrisedington @wizfinder! Me again. It appears to be an internal issue, but since I am unable to reproduce it, could you please check the repository containing sample native apps that use the Amazon IVS Broadcast iOS SDK and see if you can reproduce the problem by running |
When I build BasicBroadcast and run, I don't have errors. Only I have errors in ReactNative env with iPhone 11. |
@wizfinder hi! Thanks for the update! Do you face the same type of error by running Amazon IVS React Native Broadcast Example App? Could you also provide detailed props configuration you pass to |
I don't face the same error with Aws IVS ReactNative Broadcast Example App. I wrote test code below. if width and height value are less than about 300, it works well.
|
@wizfinder @chrisedington I am facing the same issue too. |
According to the answer you've provided, it appears that the issue might be within the project's codebase rather than with the package. Try experimenting with your component that utilizes the I will also play around with the sample app using iPhone 11 to catch any related problems. @wizfinder |
Also having this issue, I've not yet been able to find any form of workaround |
Hi, We had the same issue and found that setting the width and height of broadcast to 320 worked for iPhone6 and around 400->500 on iphonex. If not the component will flash or hang. Have not looked into the underlying native code to understand what is causing it yet. Kim |
I have been testing a variety of configuration changes and it seems somehow related to the total number of pixels being rendered? I have been unable to find any workaround for the affected devices other than reducing streaming quality, so on iphone6/7 its 320p which would be great to increase :) Anyone had any luck figuring it out? |
Hi, @AndrewShapovalov
Could you please review the changes to see if there might be any potential drawbacks? |
Thanks @dongchan0321 for this potential fix, did you have any experience with your change and if it all works ok with this implementation? |
I have tested the prolonged video streaming push on the same device where the issue was originally reproduced, and I haven't encountered any new problems so far. I plan to conduct further testing using devices of different models.
|
Thank you for replying! Yes I have tested on the devices we had issues with before and it seems to work perfectly. Now, we will also do some more testing across devices to validate before pushing it into production. Very happy you found this, as its been a bit of a hindrance for us. Even on devices like iphone 11 pro we had to reduce resolution of streaming in order to work around the issue. |
Hello everyone, Thank you all for your valuable input and code suggestions. I've taken your feedback into consideration and made changes to the same You can now try out these changes via NPM using the
Please, give it a try and provide feedback on your experiences. |
Hello, thank you for your fix. After conducting a brief real-device test, we have found that the devices that previously had issues are now functioning correctly. We have limited time for further testing at the moment, but we plan to perform additional validation with more devices in the future. |
As an fyi: |
fix: camera flashing and freezing #12
This reverts commit 5eb1656.
Hi @AndrewShapovalov
Me again 😅 I found an issue where on two sets of iPhone X and using the sample, the camera flashes green colors and freezes.
Upload.from.GitHub.for.iOS.MOV
The text was updated successfully, but these errors were encountered: