Skip to content

Commit ea593e2

Browse files
dhasani23David Hasani
andauthored
fix(amazonq): remove target JDK path prompt (#7328)
## Problem /transform was unnecessarily prompting users for their target JDK paths in some cases. ## Solution Remove the prompt. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
1 parent 340309c commit ea593e2

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Bug Fix",
3+
"description": "/transform: avoid prompting user for target JDK path unnecessarily"
4+
}

packages/core/src/amazonqGumby/chat/controller/controller.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -688,13 +688,17 @@ export class GumbyController {
688688
const pathToJavaHome = extractPath(data.message)
689689
if (pathToJavaHome) {
690690
transformByQState.setSourceJavaHome(pathToJavaHome)
691+
// TO-DO: delete line below and uncomment the block below when releasing CSB
692+
await this.prepareLanguageUpgradeProject(data.tabID)
691693
// if source and target JDK versions are the same, just re-use the source JAVA_HOME and start the build
694+
/*
692695
if (transformByQState.getTargetJDKVersion() === transformByQState.getSourceJDKVersion()) {
693696
transformByQState.setTargetJavaHome(pathToJavaHome)
694697
await this.prepareLanguageUpgradeProject(data.tabID)
695698
} else {
696699
this.promptJavaHome('target', data.tabID)
697700
}
701+
*/
698702
} else {
699703
this.messenger.sendUnrecoverableErrorResponse('invalid-java-home', data.tabID)
700704
}

0 commit comments

Comments
 (0)