NEP prefetch wip #7411
Draft
NEP prefetch wip #7411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem:
rejected promise not handled within 1 second:
Error: command 'aws.amazonq.focusChat' not found
## Solution:
Don't use `void` to ignore rejected promises.
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Problem: The `browser_download_url` in https://api.github.com/repos/aws/aws-toolkit-vscode/releases/latest points to a random artifact depending on whether toolkit or amazonq was the last release to publish. Solution: Modify the deploy logic to only set "latest" for "amazonq", never "toolkit".
## Problem `chatOptionsUpdate` notifications are not forwarded to UI. This is needed to persist previously selected model in new tabs. ## Solution Forward `chatOptionsUpdate` notifications to UI Related PR: aws/language-server-runtimes#530 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem: LSP server can't open URLs, because the LSP client does not correctly handle `ShowDocumentParams.external` requests. LSP spec: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#showDocumentParams Solution: When `ShowDocumentParams.external` is true, open the URL in a web browser instead of as a editor document.
…bilities" This reverts commit 6cbe787.
## Problem - Current telemetry version is ` 1.0.322` ## Solution - Bumping up telemetry version to ` 1.0.323` - aws/aws-toolkit-common#1034 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem Minor text update ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: David Hasani <[email protected]>
## Problem The LSP start failure because 1. node binary is blocked because of firewall 2. chat UI js file is blocked because of firewall or anti virus 3. lsp js file is broken post download because of security mechanism ## Solution 1. Bundle the JS LSP with the amazonq package. 2. Re-start LSP wth the bundled JS files if and only if downloaded LSP does not work! 3. Use the VS Code vended node to start the bundled LSP. This was tested by 1. Generated the vsix, which is now 20MB. 2. Disconnect from internet, remove local LSP caches 3. Install the new vsix 4. Webview of chat should load. also tested by manually corrupting the aws-lsp-codewhisperer.js Limitations: 1. The indexing library function will not work because it is missing. 2. rg is not in the bundle Ref: aws/aws-toolkit-jetbrains#5772 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
fix(amazonq): Add proxy configuration support with SSL Cert Validation
UX/product decision: aws account-id will be collected by the aws console instead of the client (IDE extension).
## Problem - we are missing the `mcp: true` flag ## Solution - add `mcp: true` flag to enable mcp server support --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…ws#7458) ## Problem MCP Servers feature is broken in alpha manifest and is causing regression to chat. ## Solution - reverting the feature flag to enable MCP --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
feat(amazonq): enable agentic workflow
Problem: "Manage Subscription" menu item shows for IdC users, but the Q service call does not currently support IdC users. Solution: Only show the menu item for BuilderId users.
## Problem - we are missing `mcp: true` flag ## Solution - add back `mcp: true` flag to enable mcp server support --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
fix(amazonq): remove jitter for validation call of profiles
fix(amazonq): Remove setSystemCertificates from proxyUtil
fix(amazonq): save previously-used JDK path
…r accepts EDITS suggestion
## Problem - Model selection feature flag is not enabled. ## Solution - Sent `modelSelection: true` as part of awsClientCapabilities. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem In the existing Serverless Land project, we need to check if a folder with the same name already exists before downloading the code. This could help avoid potential issues that might arise from overwriting existing files or folders. ## Solution The code checks if a folder with the same name already exists, and prompts the user to choose whether to override it or not. This allows the user to decide how to handle potential conflicts with existing files or folders. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Vandita Patidar <[email protected]>
…r accepts an EDITS suggestion
…ws#7565) ## Notes: - Migrating the /Agents(/dev, /doc and /test) to Q Agentic chat experience. - This does not disturb other /agents like /review and /transform. ### TODO: - Remove implementation code for above /agents from the VSC repository in followup PR's. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: laileni <[email protected]> Co-authored-by: Laxman Reddy <[email protected]>
## Problem ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…7617) ## Problem It's confusing when Q is saying it's thinking however sometimes the model returns empty suggestion thus nothing will be displayed to users. Thus the team decides to remove the UI. ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…tsParams for EDITS telemetry
…tsParams for EDITS telemetry (aws#7623)
## Problem WebView emit event to open system file dialog to use the VSC api to open file dialog, and the event need to be handled by extension ## Solution 1. Register the request between WebView and language server by adding `case OPEN_FILE_DIALOG` 2. Add handling for event when language server request to open system file dialog, which is defined in `languageClient.onRequest(ShowOpenDialogRequestType.method, async (params: ShowOpenDialogParams)` --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
fix(amazonq): duplicated onDidSaveTextDocument notification
…d Flare breakpoint work-around
fix(amazonq): improve feedback experience and min char limit
docs(amazonq): improve LSP documentation
## Problem Adding client side diagnostic data back after inline flare migration ## Solution Migrate existing logic for getting IDE diagnostic info and flow it to `LogInlineCompletionSessionResultsParams` Re-using https://github.com/aws/aws-toolkit-vscode/blob/ad2164b2937d324681f9504cb5a05d153c70eada/packages/core/src/codewhisperer/util/diagnosticsUtil.ts --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…s editing (NEP) (aws#7640) … ## Problem - not allow generate completion request to go through if the edit is made by Q (only affecting NEP path) - add logging - ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…Token (aws#7641) ## Problem NEP on acceptance trigger should only happen if there is a next token ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.