Skip to content

fix(amazonq): update Q profile and customizations on language-servers crash restart #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025

Conversation

floralph
Copy link
Contributor

Problem

Investigation revealed that when the language server crashed and automatically restarted, the crash recovery mechanism only sent bearer tokens but failed to send profile configuration, leaving the language server stuck in PENDING_Q_PROFILE state.

Solution

Fixed the incomplete crash recovery mechanism by:
Enhanced crash recovery handler to send both bearer token AND profile configuration during language server restart
Added comprehensive logging with context tags ([startup], [crash-recovery]) for future debugging
Created centralized authentication function to prevent code duplication between startup and crash recovery paths
Added debug logging to pushConfigUpdate and sendProfileToLsp functions to track configuration values


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@floralph floralph requested a review from a team as a code owner July 15, 2025 02:13
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@floralph floralph force-pushed the floralph/V1787412020 branch from 76acb1e to 3f34419 Compare July 16, 2025 04:11
@@ -252,6 +252,59 @@ async function initializeAuth(client: LanguageClient): Promise<AmazonQLspAuth> {
return auth
}

// jscpd:ignore-start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub checks for duplicates fails, but the code is similar, but not duplicates of what it finds.

@floralph floralph merged commit 88caf6b into master Jul 18, 2025
31 checks passed
@floralph floralph deleted the floralph/V1787412020 branch July 18, 2025 21:34
laileni-aws added a commit to laileni-aws/aws-toolkit-vscode that referenced this pull request Jul 19, 2025
…-servers crash restart (aws#7671)"

This reverts commit 88caf6b, reversing
changes made to d6fc897.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants