refactor: remove the limitation of set ckb related info (#1517)

* refactor: remove  limitation of set ckb related info

* style: add some annotation

Author: Eason Gao

core/consensus/src/util.rs

@@ -38,6 +38,8 @@ pub fn time_now() -> u64 {
 /// `keccak256` hash calculation at the end of each height. The reason why not
 /// use address directly is that the `PeerId` is binding with public key not
 /// address.
+/// The `common_ref` do not affect the signature verification, it is a
+/// placeholder.
 pub struct OverlordCrypto {
     private_key: BlsPrivateKey,
     addr_pubkey: RwLock<HashMap<Bytes, BlsPublicKey>>,

core/executor/src/system_contract/metadata/mod.rs

@@ -86,10 +86,6 @@ impl<Adapter: ExecutorAdapter + ApplyBackend> SystemContract<Adapter>
                 );
             }
             metadata_abi::MetadataContractCalls::SetCkbRelatedInfo(c) => {
-                if !adapter.block_number().is_zero() {
-                    return revert_resp(gas_limit);
-                }
-
                 exec_try!(
                     store.set_ckb_related_info(&c.info.into()),
                     gas_limit,

core/run/src/lib.rs

@@ -368,6 +368,7 @@ fn init_crypto(
         bls_pub_keys.insert(address, pub_key);
     }
 
+    // The `common_ref` is a placeholder, use empty string.
     let crypto = OverlordCrypto::new(bls_priv_key, bls_pub_keys, String::new());
     Ok(Arc::new(crypto))
 }