Skip to content

CI may be broken by illegal instruction #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KaoImin opened this issue Aug 30, 2023 · 2 comments · Fixed by #1447, #1504 or #1520
Closed

CI may be broken by illegal instruction #1387

KaoImin opened this issue Aug 30, 2023 · 2 comments · Fixed by #1447, #1504 or #1520
Assignees
Labels
github_actions Pull requests that update GitHub Actions code P-Low Priority

Comments

@KaoImin
Copy link
Contributor

KaoImin commented Aug 30, 2023

The start_with_multi_nodes test sometimes failed with the Illegal instruction error

$ fetch http://127.0.0.1:8004/ {
  method: 'POST',
  headers: { 'Content-Type': 'application/json' },
  body: '{"jsonrpc":"2.0", "method":"eth_blockNumber", "params": [], "id":42}'
}
FetchError: request to http://127.0.0.1:8001/ failed, reason: connect ECONNREFUSED 127.0.0.1:8001
    at ClientRequest.<anonymous> (file:///home/runner/.npm/_npx/721a1717bb84573e/node_modules/node-fetch/src/index.js:108:11)
    at ClientRequest.emit (node:events:[52](https://github.com/axonweb3/axon/actions/runs/6021605629/job/16334858946?pr=1382#step:4:53)6:35)
    at ClientRequest.emit (node:domain:489:12)
    at Socket.socketErrorListener (node:_http_client:501:9)
    at Socket.emit (node:events:514:28)
    at Socket.emit (node:domain:489:12)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  type: 'system',
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  erroredSysCall: 'connect'
}
/home/runner/work/_temp/003aec82-f[57](https://github.com/axonweb3/axon/actions/runs/6021605629/job/16334858946?pr=1382#step:4:58)4-4384-b2c1-fd29b13a094c.sh: line 29:  1741 Illegal instruction     (core dumped) target/debug/axon run --config devtools/chain/nodes/node_1.toml --chain-spec devtools/chain/specs/multi_nodes_short_epoch_len/chain-spec.toml > /home/runner/work/_temp/ubuntu-22.04/multi-axon-nodes/node_1.log
@chaoticlonghair
Copy link
Contributor

Possible Reason:

  • The CPU of the runner which builds the project and caches the binary file, is different with the CPU of the runner which download the binary file from caches and runs tests.

@Flouse Flouse self-assigned this Aug 30, 2023
@Flouse Flouse added github_actions Pull requests that update GitHub Actions code P-Low Priority labels Aug 30, 2023
Flouse added a commit to Flouse/axon that referenced this issue Sep 22, 2023
Flouse added a commit to Flouse/axon that referenced this issue Sep 22, 2023
Flouse added a commit to Flouse/axon that referenced this issue Sep 22, 2023
github-merge-queue bot pushed a commit that referenced this issue Sep 25, 2023
* ci: deprecate the `build-axon` workflow

due to PR #1446 and issue #1387

* ci: update the cache key for `cargo build`
@Flouse Flouse linked a pull request Sep 25, 2023 that will close this issue
7 tasks
@Flouse Flouse closed this as completed Sep 25, 2023
@Flouse Flouse reopened this Oct 27, 2023
@Flouse
Copy link
Contributor

Flouse commented Oct 27, 2023

Ckb-rocksdb uses PORTABLE=1, USE_SSE=1 by default so #1504 might NOT the right solution.

If there are runners that don't support avx2, we should use the portable feature of ckb-rocksdb to disable avx2.

Originally posted by @blckngm in #1504 (comment)


Maybe a feature switch is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code P-Low Priority
Projects
None yet
3 participants