Merge pull request #95 from patricklodder/1.3.0-prep

Release preparation for 1.3.0

Author: patricklodder

HISTORY.md

@@ -1,3 +1,10 @@
+## 1.3.0 / 2015-01-09
+
+ * Reworked DateFormatter to improve ISO-8601 implementation.
+ * Updates XMLBuilder to 2.4.
+ * Updates sax to 0.6.
+ * Adds more detail to Client request errors to ease debugging.
+
 ## 1.2.0 / 2014-01-12
 
  * Adds (tested) support for Node v0.10 and v0.11.

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2011 Brandon Ace Alexander
+Copyright (c) 2011-2015 Brandon Ace Alexander
 
 Permission is hereby granted, free of charge, to any person
 obtaining a copy of this software and associated documentation

README.md

@@ -119,17 +119,24 @@ xmlrpc.dateFormatter.setOpts({
 
 ### Cookies support
 
-It is possible to turn on cookies support for XML-RPC client by special options flag.
-If turned on then all the cookies received from server will be bounced back with subsequent calls to the server.
-You also may manipulate cookies manually by the setCookie/getCookie call.
+It is possible to turn on cookies support for XML-RPC client by special options
+flag. If turned on then all the cookies received from server will be bounced
+back with subsequent calls to the server. You also may manipulate cookies
+manually by the setCookie/getCookie call.
 
 ```javascript
-var client = xmlrpc.createClient({host: 'localhost', port: 9090, cookies: true});
+var client = xmlrpc.createClient({
+  host: 'localhost',
+  port: 9090,
+  cookies: true
+});
+
 client.setCookie('login', 'bilbo');
+
 //This call will send provided cookie to the server
 client.methodCall('someAction', [], function(error, value) {
-    //Here we may get cookie received from server if we know its name
-    console.log(client.getCookie('session'));
+  //Here we may get cookie received from server if we know its name
+  console.log(client.getCookie('session'));
 });
 
 ```

lib/date_formatter.js

@@ -52,7 +52,7 @@ DateFormatter.ISO8601 = new RegExp(
 DateFormatter.prototype.setOpts = function (opts) {
   if (!opts) opts = DateFormatter.DEFAULT_OPTIONS
 
-  var ctx = this;
+  var ctx = this
   Object.keys(DateFormatter.DEFAULT_OPTIONS).forEach(function (k) {
     ctx.opts[k] = opts.hasOwnProperty(k) ?
       opts[k] : DateFormatter.DEFAULT_OPTIONS[k]

package.json

@@ -1,7 +1,7 @@
 { "name" : "xmlrpc"
 , "description" : "A pure JavaScript XML-RPC client and server."
 , "keywords" : [ "xml-rpc", "xmlrpc", "xml", "rpc" ]
-, "version" : "1.2.0"
+, "version" : "1.3.0"
 , "preferGlobal" : false
 , "homepage" : "https://github.com/baalexander/node-xmlrpc"
 , "author" : "Brandon Alexander <[email protected]> (https://github.com/baalexander)"

test/client_test.js

@@ -5,7 +5,7 @@ var vows   = require('vows')
   , fs     = require('fs')
 
 const VALID_RESPONSE = fs.readFileSync(__dirname + '/fixtures/good_food/string_response.xml')
-const BROKEN_XML= fs.readFileSync(__dirname + '/fixtures/bad_food/broken_xml.xml')
+const BROKEN_XML = fs.readFileSync(__dirname + '/fixtures/bad_food/broken_xml.xml')
 
 vows.describe('Client').addBatch({
   //////////////////////////////////////////////////////////////////////

test/date_formatter.js

@@ -37,7 +37,7 @@ vows.describe('Date Formatter').addBatch({
           assert.isString(str)
           assert.match(str, new RegExp())
         }
-      , teardown: function () { date_formatter.setOpts(); }
+      , teardown: function () { date_formatter.setOpts() }
       }
     , "to utc representation": {
         topic: function (d) {
@@ -65,7 +65,7 @@ vows.describe('Date Formatter').addBatch({
           assert.isString(str)
           assert.match(str, new RegExp(reStr))
         }
-      , teardown: function () { date_formatter.setOpts(); }
+      , teardown: function () { date_formatter.setOpts() }
       }
     }
   }
@@ -118,6 +118,7 @@ vows.describe('Date Formatter').addBatch({
   }
 }).export(module)
 
+// HELPERS
 function encodeCase (opts, reStr) {
   return {
     topic: function (d) {
@@ -129,7 +130,7 @@ function encodeCase (opts, reStr) {
       assert.isString(str)
       assert.match(str, new RegExp(reStr))
     }
-  , teardown: function () { date_formatter.setOpts(); }
+  , teardown: function () { date_formatter.setOpts() }
   }
 }