Version 3.7.3 (#145)

* Do not test native client on not supported platforms

* Invalid cast (#144)

* prevent monitor disposing in the disable method (#143)

* Use game object name instead of 'backtrace'

* Version update + make sure backtrace-unity don't throw an exception when disk is full

* Typo

* Changelog

* Add attributes to runtime xception

Co-authored-by: Vincent Lussenburg <[email protected]>
Co-authored-by: Lysanne Pinto <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Backtrace Unity Release Notes
 
+## Version 3.7.3
+
+Bugfixes
+- Fixed the game object name issue used by native integration when ANR or background exception occured,
+- fixed invalid cast in the screenshot generation algorithm,
+- fixed a problem with the dispose method in the Backtrace Android native integration - now backtrace-unity will dispose native integation only once.
+- prevent from throwing an exception from the BacktraceDatabase object if BacktraceDatabaseAttachments object generates attachment and disk is full.
+
+
 ## Version 3.7.2
 
 Bugfixes

Runtime/BacktraceClient.cs

@@ -24,7 +24,7 @@ namespace Backtrace.Unity
     /// </summary>
     public class BacktraceClient : MonoBehaviour, IBacktraceClient
     {
-        public const string VERSION = "3.7.2";
+        public const string VERSION = "3.7.3";
         internal const string DefaultBacktraceGameObjectName = "BacktraceClient";
         public BacktraceConfiguration Configuration;
 
@@ -993,7 +993,9 @@ internal void HandleUnhandledExceptionsFromAndroidBackgroundThread(string backgr
             var stackTrace = backgroundExceptionMessage.Substring(splitIndex);
             if (Database != null)
             {
-                Database.Add(new BacktraceReport(new BacktraceUnhandledException(message, stackTrace)).ToBacktraceData(null, GameObjectDepth));
+                var backtraceData = new BacktraceReport(new BacktraceUnhandledException(message, stackTrace)).ToBacktraceData(null, GameObjectDepth);
+                AttributeProvider.AddAttributes(backtraceData.Attributes.Attributes);
+                Database.Add(backtraceData);
             }
             else
             {

Runtime/Model/Database/BacktraceDatabaseAttachmentManager.cs

@@ -31,9 +31,16 @@ public IEnumerable<string> GetReportAttachments(BacktraceData data)
             var attachmentPrefix = data.UuidString;
 
             var result = new List<string>();
-            AddIfPathIsNotEmpty(result, GetScreenshotPath(attachmentPrefix));
-            AddIfPathIsNotEmpty(result, GetUnityPlayerLogFile(data, attachmentPrefix));
-            AddIfPathIsNotEmpty(result, GetMinidumpPath(data, attachmentPrefix));
+            try
+            {
+                AddIfPathIsNotEmpty(result, GetScreenshotPath(attachmentPrefix));
+                AddIfPathIsNotEmpty(result, GetUnityPlayerLogFile(data, attachmentPrefix));
+                AddIfPathIsNotEmpty(result, GetMinidumpPath(data, attachmentPrefix));
+            }
+            catch (Exception e)
+            {
+                Debug.LogWarning(string.Format("Cannot generate report attachments. Reason: {0}", e.Message));
+            }
             return result;
         }
 
@@ -100,7 +107,7 @@ private string GetScreenshotPath(string dataPrefix)
                 {
                     Texture2D result;
 
-                    float ratio = Screen.width / Screen.height;
+                    float ratio = (float)Screen.width / (float)Screen.height;
                     var applyDefaultSettings = ScreenshotMaxHeight == Screen.height;
                     int targetHeight = applyDefaultSettings ? Screen.height : Mathf.Min(Screen.height, ScreenshotMaxHeight);
                     int targetWidth = applyDefaultSettings ? Screen.width : Mathf.RoundToInt(targetHeight * ratio);

Runtime/Native/Android/NativeClient.cs

@@ -158,12 +158,11 @@ private void HandleUnhandledExceptions()
             const string callbackName = "HandleUnhandledExceptionsFromAndroidBackgroundThread";
             try
             {
-                _unhandledExceptionWatcher = new AndroidJavaObject(_unhandledExceptionPath, "Backtrace", callbackName);
+                _unhandledExceptionWatcher = new AndroidJavaObject(_unhandledExceptionPath, GameObjectName, callbackName);
             }
             catch (Exception e)
             {
                 Debug.LogWarning(string.Format("Cannot initialize unhandled exception watcher - reason: {0}", e.Message));
-                _enabled = false;
             }
         }
 
@@ -397,7 +396,6 @@ public void HandleAnr()
             catch (Exception e)
             {
                 Debug.LogWarning(string.Format("Cannot initialize ANR watchdog - reason: {0}", e.Message));
-                _enabled = false;
             }
 
             if (!CaptureNativeCrashes)
@@ -504,11 +502,13 @@ public override void Disable()
             {
                 _anrWatcher.Call("stopMonitoring");
                 _anrWatcher.Dispose();
+                _anrWatcher = null;
             }
             if (_unhandledExceptionWatcher != null)
             {
                 _unhandledExceptionWatcher.Call("stopMonitoring");
                 _unhandledExceptionWatcher.Dispose();
+                _unhandledExceptionWatcher = null;
             }
             base.Disable();
         }

package.json

@@ -1,7 +1,7 @@
 {
   "name": "io.backtrace.unity",
   "displayName": "Backtrace",
-  "version": "3.7.2",
+  "version": "3.7.3",
   "unity": "2017.1",
   "description": "Backtrace's integration with Unity games allows customers to capture and report handled and unhandled Unity exceptions to their Backtrace instance, instantly offering the ability to prioritize and debug software errors.",
   "keywords": [