Skip to content

Commit 5b84da5

Browse files
committed
Preview 3: Fixes compilation issues on platforms without native client
1 parent dbc97da commit 5b84da5

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

Runtime/Native/Windows/NativeClient.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,13 @@ public void GetAttributes(IDictionary<string, string> attributes)
166166

167167
public void HandleAnr(string gameObjectName = "", string callbackName = "")
168168
{
169-
if (!_captureNativeCrashes || !_configuration.HandleANR)
169+
var anrDisabled =
170+
#if UNITY_STANDALONE_WIN
171+
!_captureNativeCrashes || !_configuration.HandleANR;
172+
#else
173+
true;
174+
#endif
175+
if (anrDisabled)
170176
{
171177
return;
172178
}

Tests/Runtime/Native/Windows/ScopedNativeAttributesTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
using Backtrace.Unity.Model;
22
using Backtrace.Unity.Services;
33
using NUnit.Framework;
4-
using System;
54
using System.Collections.Generic;
65
using UnityEngine;
76
using NativeClient = Backtrace.Unity.Runtime.Native.Windows.NativeClient;
7+
88
namespace Backtrace.Unity.Tests.Runtime.Native.Windows
99
{
1010
public sealed class ScopedNativeAttributesTests
@@ -43,7 +43,7 @@ public void LegacyAttributesSupport_ShouldIncludeLegacyAttributesWhenScopedAttri
4343
[Test]
4444
public void NativeCrashUploadAttributes_ShouldSetValuesInPlayerPrefs_ValuesAreAvailableInPlayerPrefs()
4545
{
46-
var configuration = new BacktraceConfiguration();
46+
var configuration = ScriptableObject.CreateInstance<BacktraceConfiguration>();
4747
configuration.SendUnhandledGameCrashesOnGameStartup = true;
4848
const string testAttributeString = "foo-key";
4949
const string testAttributeValue = "foo-bar-value";
@@ -64,7 +64,7 @@ public void NativeCrashUploadAttributesSetting_ShouldReadPlayerPrefsWithLegacyAt
6464
string sessionKey = "session-foo-bar-baz";
6565
PlayerPrefs.SetString(NativeClient.SessionKey, sessionKey);
6666

67-
var configuration = new BacktraceConfiguration();
67+
var configuration = ScriptableObject.CreateInstance<BacktraceConfiguration>();
6868
configuration.SendUnhandledGameCrashesOnGameStartup = true;
6969
const string testAttributeString = "foo-key";
7070
const string testAttributeValue = "foo-bar-value";
@@ -82,7 +82,7 @@ public void NativeCrashUploadAttributesSetting_ShouldReadPlayerPrefsWithLegacyAt
8282
public void NativeCrashUploadAttributes_ShouldSetScopedAttributeViaNativeClientApi_AttributePresentsInScopedAttributes()
8383
{
8484

85-
var configuration = new BacktraceConfiguration();
85+
var configuration = ScriptableObject.CreateInstance<BacktraceConfiguration>();
8686
configuration.SendUnhandledGameCrashesOnGameStartup = true;
8787
const string testAttributeKey = "foo-key-bar-baz";
8888
const string testAttributeValue = "123123";
@@ -104,7 +104,7 @@ public void NativeCrashAttributesCleanMethod_ShouldCleanAllScopedAttribtues_Scop
104104
PlayerPrefs.SetString(NativeClient.MachineUuidKey, machineUuid);
105105
string sessionKey = "session-foo-bar-baz";
106106
PlayerPrefs.SetString(NativeClient.SessionKey, sessionKey);
107-
var configuration = new BacktraceConfiguration();
107+
var configuration = ScriptableObject.CreateInstance<BacktraceConfiguration>();
108108
configuration.SendUnhandledGameCrashesOnGameStartup = true;
109109
const string testAttributeString = "foo-key";
110110
const string testAttributeValue = "foo-bar-value";

0 commit comments

Comments
 (0)