Validation error when adding PositionalVariant with negative position

[mathieulemieux]

When adding a new PositionalVariant record using CdsPosition, a ValidationError is raised if a negative position is typed, even if the actual Schema definition for CdsPosition allows for it: https://github.com/bcgsc/pori_graphkb_schema/blob/master/src/definitions/position.ts#L69-L80

Issue linked to SDEV-2999 and KBDEV-990.

[creisle]

You will need to make sure the client is using the same version of schema as the API

[mathieulemieux]

Ty @creisle for pointing this out. It seems they do:

• On prod GraphKB Client (v4.2.3), the Schema used is v.4.0.0 and the API is v.3.14.3.
  
• On API v3.14.3, the Schema used is indeed v.4.0.0
  

[areisle]

should I just be migrating the gui to the latest version of the schema package then?

[mathieulemieux]

should I just be migrating the gui to the latest version of the schema package then?

Hi @areisle ! Isn't it already the case? Imean, both the API and GUI using the Parser v4.0.0?

[areisle]

I mixed up those number in your image, but I'm guessing the schema version number it's displaying in the gui is just the one the api is using. if you look in the repo at the package json its v3 https://github.com/bcgsc/pori_graphkb_client/blob/master/package.json#L17

[mathieulemieux]

So the Client's About page is showing the Schema version used by the API, not the one used by the Client itself. Humm, I did not know that; ty @areisle ! So yes, I guess we should be migrating the gui to the latest version of the schema package.

[areisle]

I started working on this, but this could end up taking a long time. v3 and v4 of schema are almost completely different and a lot of things aren't in the migration guide so I'm having to look between the v3 and v4 code to figure out what changes and where things were moved or renamed.