Merge pull request #15 from blueconic/node14

Add Node14 support

Author: paulrutter

.travis.yml

@@ -6,4 +6,6 @@ node_js:
   - "10"
   - "11"
   - "12"
+  - "13"
+  - "14"
 script: npm run dummy

CHANGELOG.md

@@ -1,4 +1,8 @@
-12-10-2020  Paul Rütter
+12-10-2020 Paul Rütter
+- 2.1.0
+- Added Node 14 support
+
+12-10-2020  Paul Rütter
 - 2.0.2
 - Fix latest published version, was replaced with beta.
 

README.md

@@ -5,7 +5,7 @@ Node module which will create a V8 heap snapshot right before an "Out of Memory"
 
 It can also create heapdumps and CPU profiles on request like 'v8-profiler', but does this off-process so it doesn't interfere with execution of the main process.
 
-Tested on Node.js 7.x, 8.x, 9.x, 10.x, 11.x and 12.x.
+Tested on Node.js 7.x, 8.x, 9.x, 10.x, 11.x, 12.x, 13.x and 14.x.
 No support for Node.js < 7.0 at the moment (although this can be fixed if needed).  
 
 Also comes with prebuilt binaries (hosted on Github releases), thanks to Stuart Miller (https://github.com/spmiller).

lib/node_oom_heapdump_native.cc

@@ -73,7 +73,10 @@ void ParseArgumentsAndSetErrorHandler(const FunctionCallbackInfo<Value>& args) {
   // parse JS arguments
   // 1: filename
   // 2: addTimestamp boolean
-  #if NODE_VERSION_AT_LEAST(12, 0, 0)
+  #if NODE_VERSION_AT_LEAST(13, 0, 0)
+  Local<Context> context = isolate->GetCurrentContext();
+  String::Utf8Value fArg(isolate, args[0]->ToString(context).ToLocalChecked());
+  #elif NODE_VERSION_AT_LEAST(12, 0, 0)
   String::Utf8Value fArg(isolate, args[0]->ToString(isolate));
   #elif NODE_VERSION_AT_LEAST(9, 0, 0)
   String::Utf8Value fArg(isolate, args[0]->ToString());
@@ -93,4 +96,4 @@ void init(Local<Object> exports) {
   NODE_SET_METHOD(exports, "call", ParseArgumentsAndSetErrorHandler);
 }
 
-NODE_MODULE(NODE_OOM_HEAPDUMP_NATIVE, init)
+NODE_MODULE(NODE_OOM_HEAPDUMP_NATIVE, init)

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "node-oom-heapdump",
-  "version": "2.0.2",
+  "version": "2.1.0",
   "description": "Create a V8 heap snapshot when an \"Out of Memory\" error occurs, or create a heap snapshot or CPU profile on request.",
   "main": "index.js",
   "scripts": {
@@ -37,15 +37,15 @@
   },
   "homepage": "https://github.com/blueconic/node-oom-heapdump#readme",
   "devDependencies": {
-    "eslint-config-google": "^0.13.0"
+    "eslint-config-google": "^0.14.0"
   },
   "dependencies": {
     "bindings": "^1.5.0",
-    "chrome-remote-interface": "^0.28.0",
+    "chrome-remote-interface": "^0.28.2",
     "gc-stats": "^1.4.0",
-    "nan": "^2.14.0",
+    "nan": "^2.14.1",
     "node-pre-gyp": "^0.15.0",
     "require-main-filename": "^2.0.0",
-    "ws": "^7.1.2"
+    "ws": "^7.3.1"
   }
 }