Skip to content

Commit 6cf281d

Browse files
committed
Handle exit codes better and reject promise if so.
1 parent 5778530 commit 6cf281d

File tree

6 files changed

+16
-8
lines changed

6 files changed

+16
-8
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
06-10-2017 - Paul Rütter
2+
- 1.0.9 - Handle exit codes better and reject promise if so.
3+
14
05-10-2017 - Paul Rütter
25
- 1.0.8 - Add CPU profile functionality.
36

lib/cpuProfileWorker.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ console.error('Started CPU profile (duration: %sms) %s worker on DevTools port \
99

1010
let CDP = require('chrome-remote-interface');
1111
let writeStream = fs.createWriteStream(path);
12-
let handleError = function () {
13-
console.error(arguments);
12+
let handleError = function (arg1, arg2) {
13+
console.error("Error occurred while creating CPU profile", arg1, arg2 || "");
1414
writeStream.end();
1515
process.exit(-1);
1616
};

lib/heapdumpWorker.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,15 @@ console.error('Started heapdump %sworker for \'%s\' on DevTools port \'%s\'.', l
99

1010
let CDP = require('chrome-remote-interface');
1111
let writeStream = fs.createWriteStream(path);
12-
let handleError = function () {
13-
console.error(arguments);
12+
let handleError = function (arg1, arg2) {
13+
console.error("Error occurred while creating heapdump", arg1, arg2 || "");
1414
writeStream.end();
1515
process.exit(-1);
1616
};
1717
writeStream.on('error', (err) => {
1818
handleError("Heapdump path not valid or writable", err);
1919
});
20+
2021
CDP({
2122
host: 'localhost',
2223
port: devToolsPort,

lib/index.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,13 @@ class NodeOomHeapDumpImpl {
7676
error = err;
7777
reject(err);
7878
});
79-
child.on('exit', () => {
79+
child.on('exit', (code) => {
8080
if (!error) {
81-
resolve();
81+
if (code === 0) {
82+
resolve();
83+
} else {
84+
reject(new Error("Worker exited with statusCode: " + code));
85+
}
8286
}
8387
this._busy = false;
8488
});

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "node-oom-heapdump",
3-
"version": "1.0.8",
3+
"version": "1.0.9",
44
"description": "Create a V8 heap snapshot right before an \"Out of Memory\" error occurs, or create a heap snapshot on request.",
55
"main": "index.js",
66
"scripts": {

0 commit comments

Comments
 (0)