Skip to content

Commit 58cf82f

Browse files
ajchemistmartinklepsch
authored andcommitted
digest jar file instead jar path (#678)
In the original source, files extracted from the old jar are cached, preventing you the new jar file contents from adding to fileset, Even if the artifact is changed.
1 parent 260fe1d commit 58cf82f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGES.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ and `technomancy` for the above explanation.
3232
- Boot is officially Maven Central compatible. Make sure the `sources` and `javadoc` artifacts are on the fileset and `:classifier` is correctly set.
3333
- Environment variables BOOT_AS_ROOT, BOOT_WATCHERS_DISABLE und BOOT_COLOR accept `true` as a truthy value beside `1` and `yes` [#631][631]
3434
- Bump [pomegranate](https://github.com/cemerick/pomegranate) and [dynapath](https://github.com/tobias/dynapath) to `1.0.0`. [#612][612]
35+
- Digest `java.io.File` instead `String` path of jar at sift-action `:add-jar` method [#678][678]
3536

3637
#### Fixed
3738

@@ -47,6 +48,7 @@ and `technomancy` for the above explanation.
4748
[566]: https://github.com/boot-clj/boot/pull/566
4849
[631]: https://github.com/boot-clj/boot/issues/631
4950
[612]: https://github.com/boot-clj/boot/pull/612
51+
[678]: https://github.com/boot-clj/boot/pull/678
5052

5153
## 2.7.2
5254

boot/core/src/boot/task_helpers.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
excl (when v? [regex])
133133
jar (jar-path sym)]
134134
(core/add-cached-resource
135-
fs (digest/md5 jar) (partial pod/unpack-jar jar)
135+
fs (digest/md5 (io/file jar)) (partial pod/unpack-jar jar)
136136
:include incl :exclude excl :mergers pod/standard-jar-mergers)))
137137
(reduce fileset args))))
138138

0 commit comments

Comments
 (0)