Update test scripts to use POSIX shell

Author: brackeen

tests/build_all.sh

@@ -1,4 +1,5 @@
-#!/bin/bash
+#!/bin/sh
+#
 # Runs all tests available on this system.
 #
 # Android: Requires ANDROID_NDK_HOME set.
@@ -8,39 +9,41 @@
 # For verbose mode, use:
 # ./build_all.sh -v
 
-if ! type cmake &> /dev/null; then
-    echo "cmake not found, exiting."
-    exit -1
+if ! type cmake > /dev/null 2>&1; then
+    echo ">>> Error: cmake not found"
+    exit 1
 fi
 
 while getopts "v" OPTION; do
-  case $OPTION in
-    v) VERBOSE=1
-       ;;
-  esac
+    case $OPTION in
+        v) VERBOSE=1
+            ;;
+        *)
+            ;;
+    esac
 done
 
 run_test() {
     if [ -n "$VERBOSE" ]; then
-        echo ">>> $@"
-        "$@"
-        local result=$?
-        printf ">>> $@: "
+        echo ">>> $1"
+        "$1"
+        result=$?
+        printf ">>> %s: " "$1"
     else
         # Execute in background, showing spinner
-        printf "$@:  "
-        "$@" > /dev/null 2>&1 &
+        printf "%s:  " "$1"
+        "$1" > /dev/null 2>&1 &
         pid=$!
         i=0
         spin='-\|/'
         while kill -0 $pid 2>/dev/null; do
-            i=$(( (i + 1) % 4 ))
-            printf "\b${spin:$i:1}"
+            i=$(( i % 4 + 1 ))
+            printf "\b%s" "$(echo "$spin" | cut -c $i)"
             sleep .1
         done
         printf "\b"
         wait $pid
-        local result=$?
+        result=$?
     fi
     if [ $result -eq 0 ]; then
         echo "Success"
@@ -49,24 +52,23 @@ run_test() {
     fi
 }
 
-if [[ -z "${ANDROID_NDK_HOME}" ]]; then
+if [ -z "${ANDROID_NDK_HOME}" ]; then
     echo "./build_android.sh: Skipped (ANDROID_NDK_HOME not set)"
 else
     run_test ./build_android.sh
     run_test ./build_android_examples.sh
 fi
 
-if ! type xcodebuild &> /dev/null; then
+if ! type xcodebuild > /dev/null 2>&1; then
     echo "./build_apple.sh: Skipped (xcodebuild not found)"
 else
     run_test ./build_apple.sh
     run_test ./build_apple_examples.sh
 fi
 
-if ! type emcmake &> /dev/null; then
+if ! type emcmake > /dev/null 2>&1; then
     echo "./build_emscripten.sh: Skipped (emcmake not found)"
 else
     run_test ./build_emscripten.sh
     run_test ./build_emscripten_examples.sh
 fi
-

tests/build_android.sh

@@ -1,36 +1,35 @@
-#!/bin/bash
-if [[ -z "${ANDROID_NDK_HOME}" ]]; then
+#!/bin/sh
+
+if [ -z "${ANDROID_NDK_HOME}" ]; then
     echo "Error: ANDROID_NDK_HOME not set"
-    exit -1
+    exit 1
 fi
 
-NDK_MAJOR_VERSION=$(grep "Pkg.Revision" $ANDROID_NDK_HOME/source.properties | sed -e 's/Pkg.Revision = \([0-9]*\).*/\1/')
-if [[ "$NDK_MAJOR_VERSION" < 17 ]]; then
+NDK_MAJOR_VERSION=$(grep "Pkg.Revision" "$ANDROID_NDK_HOME"/source.properties | sed -e 's/Pkg.Revision = \([0-9]*\).*/\1/')
+if [ "$NDK_MAJOR_VERSION" -lt 17 ]; then
     echo "Error: NDK 17 or newer required"
-    exit -1
+    exit 1
 fi
 
 WIN64_MAKE=$ANDROID_NDK_HOME/prebuilt/windows-x86_64/bin/make.exe
-if [ -f $WIN64_MAKE ]; then
-    WIN64_FLAGS=(-G "Unix Makefiles" -D CMAKE_MAKE_PROGRAM=$WIN64_MAKE)
+if [ -f "$WIN64_MAKE" ]; then
+    set -- "$@" -G "Unix Makefiles" -D CMAKE_MAKE_PROGRAM="$WIN64_MAKE"
 fi
 
-declare -a abis=("armeabi-v7a" "armeabi-v7a with NEON" "arm64-v8a" "x86" "x86_64")
-
-for abi in "${abis[@]}"; do
-    if [[ "$abi" == "x86_64" && "$NDK_MAJOR_VERSION" < 19 ]]; then
+for abi in "armeabi-v7a" "armeabi-v7a with NEON" "arm64-v8a" "x86" "x86_64"; do
+    if [ "$abi" = "x86_64" ] && [ "$NDK_MAJOR_VERSION" -lt 19 ]; then
         # An error in NDK 18 (and older) prevents CMake from finding x86_64 libraries.
-        echo ">>> Skipping ABI $abi (NDK 19 or newer required)"
+        echo ">>> Android: Skipping ABI $abi (NDK 19 or newer required)"
         continue
     fi
-    echo ">>> Building ABI $abi"
-    rm -Rf "build/android_$abi"
+    echo ">>> Android: Building ABI $abi"
+    rm -rf "build/android_$abi"
     cmake -S .. -B "build/android_$abi" \
         -D GLFM_USE_CLANG_TIDY=ON \
-        -D CMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake \
+        -D CMAKE_TOOLCHAIN_FILE="$ANDROID_NDK_HOME"/build/cmake/android.toolchain.cmake \
         -D CMAKE_C_FLAGS=-Werror \
         -D CMAKE_VERBOSE_MAKEFILE=ON \
         -D ANDROID_ABI="$abi" \
-        "${WIN64_FLAGS[@]}" || exit $?
+        "$@" || exit $?
     cmake --build "build/android_$abi" || exit $?
 done

tests/build_android_examples.sh

@@ -1,25 +1,26 @@
-#!/bin/bash
-if [[ -z "${ANDROID_NDK_HOME}" ]]; then
+#!/bin/sh
+
+if [ -z "${ANDROID_NDK_HOME}" ]; then
     echo "Error: ANDROID_NDK_HOME not set"
-    exit -1
+    exit 1
 fi
 
-NDK_MAJOR_VERSION=$(grep "Pkg.Revision" $ANDROID_NDK_HOME/source.properties | sed -e 's/Pkg.Revision = \([0-9]*\).*/\1/')
-if [[ "$NDK_MAJOR_VERSION" < 17 ]]; then
+NDK_MAJOR_VERSION=$(grep "Pkg.Revision" "$ANDROID_NDK_HOME"/source.properties | sed -e 's/Pkg.Revision = \([0-9]*\).*/\1/')
+if [ "$NDK_MAJOR_VERSION" -lt 17 ]; then
     echo "Error: NDK 17 or newer required"
-    exit -1
+    exit 1
 fi
 
 WIN64_MAKE=$ANDROID_NDK_HOME/prebuilt/windows-x86_64/bin/make.exe
-if [ -f $WIN64_MAKE ]; then
-    WIN64_FLAGS=(-G "Unix Makefiles" -D CMAKE_MAKE_PROGRAM=$WIN64_MAKE)
+if [ -f "$WIN64_MAKE" ]; then
+    set -- "$@" -G "Unix Makefiles" -D CMAKE_MAKE_PROGRAM="$WIN64_MAKE"
 fi
 
-rm -Rf build/android_examples
+rm -rf build/android_examples
 cmake -D GLFM_BUILD_EXAMPLES=ON \
-    -D CMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake \
+    -D CMAKE_TOOLCHAIN_FILE="$ANDROID_NDK_HOME"/build/cmake/android.toolchain.cmake \
     -D CMAKE_C_FLAGS=-Werror=deprecated-declarations \
     -D CMAKE_VERBOSE_MAKEFILE=ON \
-    "${WIN64_FLAGS[@]}" \
+    "$@" \
     -S .. -B build/android_examples || exit $?
 cmake --build build/android_examples || exit $?

tests/build_apple.sh

@@ -1,64 +1,60 @@
-#!/bin/bash
-if ! type xcodebuild &> /dev/null; then
+#!/bin/sh
+
+if ! type xcodebuild > /dev/null 2>&1; then
     echo "Error: xcodebuild not found"
-    exit -1
+    exit 1
 fi
-if ! type xcpretty &> /dev/null; then
+if ! type xcpretty > /dev/null 2>&1; then
     echo ">>> Skipping analyze step: xcpretty not found"
 else
     has_xcpretty=1
 fi
 
 # Find clang-tidy either in the path or installed via brew
-clang_tidy=$(which clang-tidy 2>/dev/null || which $(brew --prefix llvm)/bin/clang-tidy 2>/dev/null)
-if [ $? -ne 0 ]; then
+if ! clang_tidy=$(which clang-tidy 2>/dev/null || which "$(brew --prefix llvm)"/bin/clang-tidy 2>/dev/null); then
     echo ">>> Skipping analyze step: clang-tidy not found"
 else
     has_clang_tidy=1
 fi
 
 export CFLAGS=-Werror
 
-declare -a sdks=("appletvos" "appletvsimulator" "iphoneos" "iphonesimulator" "macosx")
-declare -a objc_arc_names=("objc_arc_on" "objc_arc_off")
-declare -a objc_arc_values=("YES" "NO")
-
 # Check failure when cmake piped to xcpretty
 set -o pipefail
 
-for i in "${!objc_arc_names[@]}"; do
-    builddir="build/apple_${objc_arc_names[i]}"
+for objc_arc in YES NO; do
+    builddir="build/apple_objc_arc_$objc_arc"
 
-    rm -Rf $builddir
+    rm -rf "$builddir"
 
-    cmake -S .. -B $builddir \
+    cmake -S .. -B "$builddir" \
         -G Xcode \
         -D CMAKE_XCODE_ATTRIBUTE_ONLY_ACTIVE_ARCH=NO \
-        -D CMAKE_XCODE_ATTRIBUTE_CLANG_ENABLE_OBJC_ARC=${objc_arc_values[i]} || exit $?
+        -D CMAKE_XCODE_ATTRIBUTE_CLANG_ENABLE_OBJC_ARC="$objc_arc" || exit $?
 
-    for sdk in "${sdks[@]}"; do
-        echo ">>> Building $sdk (${objc_arc_names[i]})"
-        if [ ! $has_xcpretty ] || [ ! $has_clang_tidy ]; then
-            cmake --build $builddir -- -sdk $sdk || exit $?
+    for sdk in appletvos appletvsimulator iphoneos iphonesimulator macosx; do
+        echo ">>> Apple: Building $sdk (OBJC_ARC=$objc_arc)"
+        if [ ! "$has_xcpretty" ] || [ ! "$has_clang_tidy" ]; then
+            cmake --build "$builddir" -- -sdk "$sdk" || exit $?
         else
-            cmake --build $builddir -- -sdk $sdk \
-                | xcpretty -r json-compilation-database --output $builddir/compile_commands.json || exit $?
+            cmake --build "$builddir" -- -sdk "$sdk" \
+                | xcpretty -r json-compilation-database --output "$builddir"/compile_commands.json || exit $?
 
             # Don't analyze simulators, which share code (building is included to targeting multiple archs)
-            if [[ $sdk = *simulator ]]; then
+            if echo "$sdk" | grep -q "simulator"; then
                 continue
             fi
 
-            echo ">>> Analyzing $sdk (${objc_arc_names[i]})"
+            echo ">>> Apple: Analyzing $sdk (OBJC_ARC=$objc_arc)"
 
             # Remove "ivfsstatcache" flag from compile_commands.json.
             # Current clang-tidy version (16.0.1) doesn't understand "ivfsstatcache" flag from xcodebuild 14.3.
-            sed -i.bak 's/ -ivfsstatcache [^ ]* / /g' $builddir/compile_commands.json
+            sed -i.bak 's/ -ivfsstatcache [^ ]* / /g' "$builddir"/compile_commands.json
 
             # Use compile_commands.json generated from xcpretty to run clang-tidy. This will also check header files.
             # Since GLFM for Apple has only one source file, it is easy to just specify glfm_apple.m.
             # For bigger projects, the filenames could be parsed from compile_commands.json.
-            $clang_tidy --config-file=clang-tidy-analyze.yml -p $builddir ../src/glfm_apple.m || exit $?
+            $clang_tidy --config-file=clang-tidy-analyze.yml -p "$builddir" ../src/glfm_apple.m || exit $?
         fi
     done
 done

tests/build_apple_examples.sh

@@ -1,21 +1,20 @@
-#!/bin/bash
-if ! type xcodebuild &> /dev/null; then
+#!/bin/sh
+
+if ! type xcodebuild > /dev/null 2>&1; then
     echo "Error: xcodebuild not found"
-    exit -1
+    exit 1
 fi
 
 export CFLAGS=-Werror=deprecated-declarations
-declare -a sdks=("appletvos" "iphoneos" "macosx")
 
-rm -Rf build/apple_examples
+rm -rf build/apple_examples
 
 cmake -S .. -B build/apple_examples -G Xcode \
     -D GLFM_BUILD_EXAMPLES=ON \
     -D CMAKE_XCODE_ATTRIBUTE_CODE_SIGN_IDENTITY="" \
     -D CMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED=NO || exit $?
 
-for sdk in "${sdks[@]}"; do
-    echo ">>> Building examples for $sdk"
-    cmake --build build/apple_examples -- -sdk ${sdk} || exit $?
+for sdk in appletvos iphoneos macosx; do
+    echo ">>> Apple: Building examples for $sdk"
+    cmake --build build/apple_examples -- -sdk "$sdk" || exit $?
 done
-

tests/build_emscripten.sh

@@ -1,12 +1,13 @@
-#!/bin/bash
-if ! type emcmake &> /dev/null; then
+#!/bin/sh
+
+if ! type emcmake > /dev/null 2>&1; then
     echo "Error: emcmake not found"
-    exit -1
+    exit 1
 fi
 
 export CFLAGS=-Werror
 
-rm -Rf build/emscripten
+rm -rf build/emscripten
 emcmake cmake -S .. -B build/emscripten \
     -D GLFM_USE_CLANG_TIDY=ON \
     -D CMAKE_VERBOSE_MAKEFILE=ON || exit $?

tests/build_emscripten_examples.sh

@@ -1,12 +1,13 @@
-#!/bin/bash
-if ! type emcmake &> /dev/null; then
+#!/bin/sh
+
+if ! type emcmake > /dev/null 2>&1; then
     echo "Error: emcmake not found"
-    exit -1
+    exit 1
 fi
 
 export CFLAGS=-Werror=deprecated-declarations
 
-rm -Rf build/emscripten_examples
+rm -rf build/emscripten_examples
 emcmake cmake -S .. -B build/emscripten_examples \
     -D GLFM_BUILD_EXAMPLES=ON \
     -D CMAKE_VERBOSE_MAKEFILE=ON || exit $?