Skip to content

Commit 491b389

Browse files
authored
rename subquery to inner query (#107)
1 parent 48f9287 commit 491b389

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

src/main/java/com/yahoo/bullet/common/BulletConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public class BulletConfig extends Config {
112112
makeMetadata(ImmutablePair.of(Concept.QUERY_METADATA, "Query"),
113113
ImmutablePair.of(Concept.QUERY_ID, "ID"),
114114
ImmutablePair.of(Concept.QUERY_STRING, "Query String"),
115-
ImmutablePair.of(Concept.SUBQUERY_METADATA, "Subquery"),
115+
ImmutablePair.of(Concept.INNER_QUERY_METADATA, "Inner Query"),
116116
ImmutablePair.of(Concept.QUERY_RECEIVE_TIME, "Receive Time"),
117117
ImmutablePair.of(Concept.QUERY_FINISH_TIME, "Finish Time"),
118118
ImmutablePair.of(Concept.SKETCH_METADATA, "Sketch"),

src/main/java/com/yahoo/bullet/querying/Querier.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ private Clip outerQuery(Clip clip) {
681681
querier.consumeRecord(record);
682682
}
683683
Clip result = querier.getResult();
684-
result.getMeta().add(getSubMetaKey(), clip.getMeta().asMap());
684+
result.getMeta().add(getInnerQueryMetaKey(), clip.getMeta().asMap());
685685
return result;
686686
}
687687

@@ -725,7 +725,7 @@ private String getMetaKey() {
725725
return metaKeys.getOrDefault(Concept.QUERY_METADATA.getName(), null);
726726
}
727727

728-
private String getSubMetaKey() {
729-
return metaKeys.getOrDefault(Concept.SUBQUERY_METADATA.getName(), null);
728+
private String getInnerQueryMetaKey() {
729+
return metaKeys.getOrDefault(Concept.INNER_QUERY_METADATA.getName(), null);
730730
}
731731
}

src/main/java/com/yahoo/bullet/result/Meta.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public enum Concept {
3131
QUERY_ID("Query ID"),
3232
QUERY_OBJECT("Query Object"),
3333
QUERY_STRING("Query String"),
34-
SUBQUERY_METADATA("Subquery Metadata"),
34+
INNER_QUERY_METADATA("Inner Query Metadata"),
3535

3636
// Sketching metadata
3737
SKETCH_METADATA("Sketch Metadata"),

src/main/resources/bullet_defaults.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,8 @@ bullet.result.metadata.metrics:
166166
key: "Receive Time"
167167
- name: "Query Finish Time"
168168
key: "Finish Time"
169-
- name: "Subquery Metadata"
170-
key: "Subquery"
169+
- name: "Inner Query Metadata"
170+
key: "Inner Query"
171171
- name: "Sketch Metadata"
172172
key: "Sketch"
173173
- name: "Sketch Estimated Result"

src/test/java/com/yahoo/bullet/querying/QuerierTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -934,6 +934,6 @@ public void testOuterQuery() {
934934

935935
Map<String, Object> metadata = result.getMeta().asMap();
936936

937-
Assert.assertTrue(metadata.containsKey("Subquery"));
937+
Assert.assertTrue(metadata.containsKey("Inner Query"));
938938
}
939939
}

0 commit comments

Comments
 (0)