Publish content-type application/json (#20)

Author: NathanSpeidel

src/main/java/com/yahoo/bullet/pubsub/rest/RESTPublisher.java

@@ -16,6 +16,9 @@
 
 @Slf4j
 public abstract class RESTPublisher implements Publisher {
+    public static final String APPLICATION_JSON = "application/json";
+    public static final String CONTENT_TYPE = "content-type";
+
     private AsyncHttpClient client;
 
     /**
@@ -46,7 +49,7 @@ protected void sendToURL(String url, PubSubMessage message) {
         log.debug("Sending message: {} to url: {}", message, url);
         client.preparePost(url)
               .setBody(message.asJSON())
-              .setHeader("content-type", "text/plain")
+              .setHeader(CONTENT_TYPE, APPLICATION_JSON)
               .execute()
               .toCompletableFuture()
               .exceptionally(this::handleException)

src/test/java/com/yahoo/bullet/pubsub/rest/RESTQueryPublisherTest.java

@@ -38,7 +38,7 @@ public void testSendResultUrlPutInMetadataAckPreserved() throws Exception {
         publisher.send(new PubSubMessage("foo", "bar", Metadata.Signal.ACKNOWLEDGE));
         verify(mockClient).preparePost("my/custom/query/url");
         verify(mockBuilder).setBody("{\"id\":\"foo\",\"sequence\":-1,\"content\":\"bar\",\"metadata\":{\"signal\":\"ACKNOWLEDGE\",\"content\":\"my/custom/url\"}}");
-        verify(mockBuilder).setHeader("content-type", "text/plain");
+        verify(mockBuilder).setHeader(RESTPublisher.CONTENT_TYPE, RESTPublisher.APPLICATION_JSON);
     }
 
     @Test
@@ -53,7 +53,7 @@ public void testSendResultUrlPutInMetadataCompletePreserved() throws Exception {
         publisher.send(new PubSubMessage("foo", "bar", Metadata.Signal.COMPLETE));
         verify(mockClient).preparePost("my/custom/query/url");
         verify(mockBuilder).setBody("{\"id\":\"foo\",\"sequence\":-1,\"content\":\"bar\",\"metadata\":{\"signal\":\"COMPLETE\",\"content\":\"my/custom/result/url\"}}");
-        verify(mockBuilder).setHeader("content-type", "text/plain");
+        verify(mockBuilder).setHeader(RESTPublisher.CONTENT_TYPE, RESTPublisher.APPLICATION_JSON);
     }
 
     @Test
@@ -66,7 +66,7 @@ public void testSendMetadataCreated() throws Exception {
         publisher.send("foo", "bar");
         verify(mockClient).preparePost("my/custom/query/url");
         verify(mockBuilder).setBody("{\"id\":\"foo\",\"sequence\":-1,\"content\":\"bar\",\"metadata\":{\"signal\":null,\"content\":\"my/custom/result/url\"}}");
-        verify(mockBuilder).setHeader("content-type", "text/plain");
+        verify(mockBuilder).setHeader(RESTPublisher.CONTENT_TYPE, RESTPublisher.APPLICATION_JSON);
     }
 
     @Test
@@ -99,7 +99,7 @@ public void testHandleBadResponse() throws Exception {
         publisher.send(new PubSubMessage("foo", "bar", Metadata.Signal.COMPLETE));
         verify(mockClient).preparePost("my/custom/query/url");
         verify(mockBuilder).setBody("{\"id\":\"foo\",\"sequence\":-1,\"content\":\"bar\",\"metadata\":{\"signal\":\"COMPLETE\",\"content\":\"my/custom/result/url\"}}");
-        verify(mockBuilder).setHeader("content-type", "text/plain");
+        verify(mockBuilder).setHeader(RESTPublisher.CONTENT_TYPE, RESTPublisher.APPLICATION_JSON);
     }
 
     @Test(timeOut = 5000L)

src/test/java/com/yahoo/bullet/pubsub/rest/RESTResultPublisherTest.java

@@ -35,7 +35,7 @@ public void testSend() throws Exception {
         publisher.send(message);
         verify(mockClient).preparePost("custom/url");
         verify(mockBuilder).setBody("{\"id\":\"someId\",\"sequence\":-1,\"content\":\"someContent\",\"metadata\":{\"signal\":null,\"content\":\"custom/url\"}}");
-        verify(mockBuilder).setHeader("content-type", "text/plain");
+        verify(mockBuilder).setHeader(RESTPublisher.CONTENT_TYPE, RESTPublisher.APPLICATION_JSON);
     }
 
     @Test(expectedExceptions = ClassCastException.class)