Skip to content

Cleanup won't be called if caddy fails to use the new configuration and reverts to the old configuration #7067

Open
@WeidiDeng

Description

@WeidiDeng

I recently noticed one of my caddy module would continue to run in the background if the new caddy config failed to run. It implements caddy.CleanerUpper which will stop the background goroutine if called.

It happens because the new caddy config was partially in provisioned when later other modules failed to be provisioned. However, at this point the background goroutine had been started and failed to be cleaned up.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions