Skip to content

Replaced deprecated set-output #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lfgcampos
Copy link

What does this PR introduce?

@benschwarz, I have to say I haven't tested it completely but the change seemed to be straightforward.
Sorry if I am missing something easy/stupid here =)

Reviewers

@lfgcampos lfgcampos requested a review from benschwarz as a code owner April 22, 2024 09:50
@lfgcampos
Copy link
Author

hi @benschwarz, sorry to ping you on this but any news on it?

@benschwarz
Copy link
Member

apologies for the delay @lfgcampos.

afaik you can use >> $GITHUB_OUTPUT (in bash) to push into the GITHUB_OUTPUT environment variable, but that isn't going to be a viable option from a node console log.

I think the path forward here would be to introduce @actions/core and the setOutput function, e.g.:

core.setOutput('markdown', escapedMarkdown);

@lfgcampos
Copy link
Author

hey @benschwarz, long long time but I tried to get back to this today and failed
main reason is that I can't build it properly locally as node/npm versions are a mismatch and it also complains about some of the image compression libs which are not available for my OS =/

hence, I can't add a new dev into npm and update it properly

I am afraid I won't be able to finish it =(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Usage of deprecated command
2 participants