bug(email-connector): fix for inbound email connector when an email cant be moved 3

Author: mathias-vandaele

connectors/email/src/main/java/io/camunda/connector/email/client/jakarta/inbound/PollingManager.java

@@ -6,6 +6,7 @@
  */
 package io.camunda.connector.email.client.jakarta.inbound;
 
+import io.camunda.connector.api.error.ConnectorException;
 import io.camunda.connector.api.error.ConnectorRetryException;
 import io.camunda.connector.api.inbound.*;
 import io.camunda.connector.email.authentication.Authentication;
@@ -120,7 +121,9 @@ private void pollAllAndProcess(PollAll pollAll) {
       Message[] messages = this.folder.getMessages();
       Arrays.stream(messages).forEach(message -> this.processMail((IMAPMessage) message, pollAll));
     } catch (Exception e) {
-      manageException(e);
+      this.connectorContext.log(
+              Activity.level(Severity.ERROR).tag("mail-polling").message(e.getMessage()));
+      this.connectorContext.cancel(new ConnectorException(e.getMessage(), e));
     }
   }
 
@@ -131,20 +134,20 @@ private void pollUnseenAndProcess(PollUnseen pollUnseen) {
       Arrays.stream(unseenMessages)
           .forEach(message -> this.processMail((IMAPMessage) message, pollUnseen));
     } catch (Exception e) {
-      manageException(e);
+      this.connectorContext.log(
+              Activity.level(Severity.ERROR).tag("mail-polling").message(e.getMessage()));
+      this.connectorContext.cancel(
+              ConnectorRetryException.builder()
+                      .cause(e)
+                      .message(e.getMessage())
+                      .retries(2)
+                      .backoffDuration(Duration.of(3, ChronoUnit.SECONDS))
+                      .build());
     }
   }
 
   private void manageException(Exception e) {
-    this.connectorContext.log(
-        Activity.level(Severity.ERROR).tag("mail-polling").message(e.getMessage()));
-    this.connectorContext.cancel(
-        ConnectorRetryException.builder()
-            .cause(e)
-            .message(e.getMessage())
-            .retries(2)
-            .backoffDuration(Duration.of(3, ChronoUnit.SECONDS))
-            .build());
+
   }
 
   private void processMail(IMAPMessage message, PollingConfig pollingConfig) {

connectors/email/src/main/java/io/camunda/connector/email/client/jakarta/utils/JakartaUtils.java

@@ -284,8 +284,8 @@ private void processBodyPart(
       throws MessagingException, IOException {
     BodyPart bodyPart = multipart.getBodyPart(i);
     switch (bodyPart.getContent()) {
-      case InputStream attachment
-          when Part.ATTACHMENT.equalsIgnoreCase(bodyPart.getDisposition()) ->
+      case InputStream attachment when Part.ATTACHMENT.equalsIgnoreCase(
+              bodyPart.getDisposition()) ->
           emailBodyBuilder.addAttachment(
               new EmailAttachment(
                   attachment,