Merge pull request #501 from zenhack/simplify-handleCancel

lthibault · web-flow · commit 67bc9cbf3ee4 · 2023-04-11T13:00:27.000-04:00
handleCancel: minor simplification.
diff --git a/rpc/question.go b/rpc/question.go
@@ -130,7 +130,7 @@ func (q *question) handleCancel(ctx context.Context) {
 
 			q.p.Reject(rejectErr)
 			if q.bootstrapPromise != nil {
-				q.bootstrapPromise.Fulfill(q.p.Answer().Client())
+				q.bootstrapPromise.Reject(rejectErr)
 				q.p.ReleaseClients()
 			}
 		})

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ func (q *question) handleCancel(ctx context.Context) {`
`130`	`130`
`131`	`131`	`q.p.Reject(rejectErr)`
`132`	`132`	`if q.bootstrapPromise != nil {`
`133`		`- q.bootstrapPromise.Fulfill(q.p.Answer().Client())`
	`133`	`+ q.bootstrapPromise.Reject(rejectErr)`
`134`	`134`	`q.p.ReleaseClients()`
`135`	`135`	`}`
`136`	`136`	`})`