Merge pull request #11 from clean-arch-enablers-project/refact/new-api

zeluciojr · web-flow · commit fa8ca1835d5d · 2025-03-11T02:13:29.000-03:00
new API
diff --git a/pom.xml b/pom.xml
@@ -8,7 +8,7 @@
     <url>https://github.com/clean-arch-enablers-project/cae-utils-http-client/blob/main/README.md</url>
     <groupId>com.clean-arch-enablers</groupId>
     <artifactId>cae-http-client</artifactId>
-    <version>1.1.0</version>
+    <version>2.0.0</version>
     <packaging>jar</packaging>
     <licenses>
         <license>
diff --git a/src/main/java/com/cae/http_client/CaeHttpClient.java b/src/main/java/com/cae/http_client/CaeHttpClient.java
@@ -5,12 +5,12 @@
 import lombok.NoArgsConstructor;
 
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class CaeHttpClientFactory {
+public class CaeHttpClient {
 
     public static final HttpRequestStarter REQUEST_STARTER = new HttpRequestStarterImplementation();
 
-    public static HttpRequestStarter getSingletonClient(){
-        return CaeHttpClientFactory.REQUEST_STARTER;
+    public static HttpRequestStarter getStarter(){
+        return CaeHttpClient.REQUEST_STARTER;
     }
 
 }
diff --git a/src/main/java/com/cae/http_client/HttpRequestBuilder.java b/src/main/java/com/cae/http_client/HttpRequestBuilder.java
@@ -1,12 +1,12 @@
 package com.cae.http_client;
 
-public interface HttpRequestBuilder extends HttpRequestBuilderForHandlers, HttpRequestBuilderForRetrying{
+public interface HttpRequestBuilder extends HttpRequestBuilderForHandlers{
 
     HttpRequestBuilder headerOf(String key, String value);
     HttpRequestBuilder headersFactory(HttpRequestHeaderFactory httpRequestHeaderFactory);
     HttpRequestBuilder pathVariableOf(String pathVariablePlaceholder, String pathVariableValue);
     HttpRequestBuilder queryParameterOf(String queryParameterName, String queryParameterValue);
     HttpRequestBuilder proxyAddress(String host, Integer port);
-    HttpRequestModel finishBuildingModel();
+    HttpRequestModel buildRequestModel();
 
 }
diff --git a/src/main/java/com/cae/http_client/HttpRequestBuilderForRetrying.java b/src/main/java/com/cae/http_client/HttpRequestBuilderForRetrying.java
@@ -2,7 +2,7 @@
 
 import com.cae.http_client.commons.RetriersByExceptionTypeFactory;
 
-public interface HttpRequestBuilderForRetrying {
+interface HttpRequestBuilderForRetrying {
 
     HttpRequestBuilder retrierByHttpStatusCode(Integer statusCode, RetrierModel retrierModel);
     HttpRequestBuilder retriersByHttpStatusCodeFactory(RetriersByStatusCodeFactory retriersByStatusCodeFactory);
diff --git a/src/main/java/com/cae/http_client/HttpRequestMethod.java b/src/main/java/com/cae/http_client/HttpRequestMethod.java
@@ -2,10 +2,9 @@
 
 
 import com.cae.http_client.implementations.AbstractHttpRequestModel;
-import com.cae.http_client.implementations.exceptions.RetryNeededOnExceptionThrownException;
 
 public interface HttpRequestMethod {
 
-    HttpResponse execute(AbstractHttpRequestModel httpRequestModel) throws RetryNeededOnExceptionThrownException;
+    HttpResponse execute(AbstractHttpRequestModel httpRequestModel);
 
 }
diff --git a/src/main/java/com/cae/http_client/RetriersByStatusCodeFactory.java b/src/main/java/com/cae/http_client/RetriersByStatusCodeFactory.java
@@ -4,5 +4,5 @@
 
 import java.util.Map;
 
-public interface RetriersByStatusCodeFactory extends RetriersFactory<Map<Integer, RetrierModel>> {
+interface RetriersByStatusCodeFactory extends RetriersFactory<Map<Integer, RetrierModel>> {
 }
diff --git a/src/main/java/com/cae/http_client/RetryCounter.java b/src/main/java/com/cae/http_client/RetryCounter.java
@@ -1,6 +1,6 @@
 package com.cae.http_client;
 
-public interface RetryCounter {
+interface RetryCounter {
     boolean thereIsRetryAvailable();
     void decreaseRetriesAvailable();
 }
diff --git a/src/main/java/com/cae/http_client/implementations/AbstractHttpRequestModel.java b/src/main/java/com/cae/http_client/implementations/AbstractHttpRequestModel.java
@@ -20,7 +20,5 @@ public abstract class AbstractHttpRequestModel implements HttpRequestModel {
     protected HttpResponseHandler genericResponseHandler;
     protected final Map<Integer, HttpResponseHandler> responseHandlersByStatusCode = new HashMap<>();
     protected final Map<Class<? extends Exception>, ExceptionHandler> exceptionHandlersByExceptionType = new HashMap<>();
-    protected final Map<Integer, RetryCounter> retryCountersByStatusCode = new HashMap<>();
-    protected final Map<Class<? extends Exception>, RetryCounter> retryCountersByExceptionType = new HashMap<>();
 
 }
diff --git a/src/main/java/com/cae/http_client/implementations/ExceptionThrownByHttpRequestChecker.java b/src/main/java/com/cae/http_client/implementations/ExceptionThrownByHttpRequestChecker.java
@@ -1,6 +1,5 @@
 package com.cae.http_client.implementations;
 
-import com.cae.http_client.implementations.exceptions.RetryNeededOnExceptionThrownException;
 import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 
@@ -16,11 +15,6 @@ public static ExceptionThrownByHttpRequestChecker of(AbstractHttpRequestModel ht
     }
 
     public void checkOn(Exception e) {
-        var retryCounterByExceptionType = ofNullable(this.httpRequestModel.retryCountersByExceptionType.get(e.getClass()));
-        if (retryCounterByExceptionType.isPresent() && retryCounterByExceptionType.get().thereIsRetryAvailable()) {
-            retryCounterByExceptionType.get().decreaseRetriesAvailable();
-            throw new RetryNeededOnExceptionThrownException(e.getClass());
-        }
         var handlerByThisException = ofNullable(this.httpRequestModel.exceptionHandlersByExceptionType.get(e.getClass()));
         handlerByThisException.ifPresent(handler -> handler.handle(e));
     }
diff --git a/src/main/java/com/cae/http_client/implementations/HttpRequestBuilderImplementation.java b/src/main/java/com/cae/http_client/implementations/HttpRequestBuilderImplementation.java
@@ -2,7 +2,6 @@
 
 
 import com.cae.http_client.*;
-import com.cae.http_client.commons.RetriersByExceptionTypeFactory;
 
 public class HttpRequestBuilderImplementation extends AbstractHttpRequestBuilder {
 
@@ -45,7 +44,7 @@ public HttpRequestBuilder proxyAddress(String host, Integer port) {
     }
 
     @Override
-    public HttpRequestModel finishBuildingModel() {
+    public HttpRequestModel buildRequestModel() {
         return this.httpRequest;
     }
 
@@ -79,27 +78,4 @@ public HttpRequestBuilder handlersByExceptionTypeFactory(HttpExceptionHandlersBy
         return this;
     }
 
-    @Override
-    public HttpRequestBuilder retrierByHttpStatusCode(Integer statusCode, RetrierModel retrierModel) {
-        this.httpRequest.retryCountersByStatusCode.put(statusCode, RetryCounterImplementation.of(retrierModel));
-        return this;
-    }
-
-    @Override
-    public HttpRequestBuilder retriersByHttpStatusCodeFactory(RetriersByStatusCodeFactory retriersByStatusCodeFactory) {
-        retriersByStatusCodeFactory.makeRetriers().forEach((statusCode, retrierModel) -> this.httpRequest.retryCountersByStatusCode.put(statusCode, RetryCounterImplementation.of(retrierModel)));
-        return this;
-    }
-
-    @Override
-    public HttpRequestBuilder retrierByExceptionType(Class<? extends Exception> exceptionType, RetrierModel retrierModel) {
-        this.httpRequest.retryCountersByExceptionType.put(exceptionType, RetryCounterImplementation.of(retrierModel));
-        return this;
-    }
-
-    @Override
-    public HttpRequestBuilder retriersByExceptionTypeFactory(RetriersByExceptionTypeFactory retriersByExceptionTypeFactory) {
-        retriersByExceptionTypeFactory.makeRetriers().forEach((exceptionType, retrierModel) -> this.httpRequest.retryCountersByExceptionType.put(exceptionType, RetryCounterImplementation.of(retrierModel)));
-        return this;
-    }
 }
diff --git a/src/main/java/com/cae/http_client/implementations/HttpRequestDeleteMethod.java b/src/main/java/com/cae/http_client/implementations/HttpRequestDeleteMethod.java
@@ -3,12 +3,11 @@
 
 import com.cae.http_client.HttpRequestMethod;
 import com.cae.http_client.HttpResponse;
-import com.cae.http_client.implementations.exceptions.RetryNeededOnExceptionThrownException;
 
 public class HttpRequestDeleteMethod implements HttpRequestMethod {
 
     @Override
-    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) throws RetryNeededOnExceptionThrownException {
+    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) {
         var finalRequest = FinalHttpRequestFactory.makeFinalRequestForDeleteMethodFrom(httpRequestModel);
         try {
             var unwrappedResponse = FinalHttpRequestExecutor.of(httpRequestModel).execute(finalRequest);
diff --git a/src/main/java/com/cae/http_client/implementations/HttpRequestExecutionManager.java b/src/main/java/com/cae/http_client/implementations/HttpRequestExecutionManager.java
@@ -1,8 +1,6 @@
 package com.cae.http_client.implementations;
 
 import com.cae.http_client.HttpResponse;
-import com.cae.http_client.implementations.exceptions.RetryNeededOnExceptionThrownException;
-import com.cae.http_client.implementations.exceptions.RetryNeededOnHttpStatusCodeException;
 import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 
@@ -18,13 +16,9 @@ static HttpRequestExecutionManager of(AbstractHttpRequestModel httpRequest){
     }
 
     protected HttpResponse run() {
-        try {
-            var response = this.httpRequest.method.execute(this.httpRequest);
-            response.ifNeedsHandling(HttpResponseStatusCodeChecker.of(this.httpRequest)::checkOutHandlersFor);
-            return response;
-        } catch (RetryNeededOnHttpStatusCodeException | RetryNeededOnExceptionThrownException exception) {
-            return this.run();
-        }
+        var response = this.httpRequest.method.execute(this.httpRequest);
+        response.ifNeedsHandling(HttpResponseStatusCodeChecker.of(this.httpRequest)::checkOutHandlersFor);
+        return response;
     }
 
 }
diff --git a/src/main/java/com/cae/http_client/implementations/HttpRequestGetMethod.java b/src/main/java/com/cae/http_client/implementations/HttpRequestGetMethod.java
@@ -3,12 +3,11 @@
 
 import com.cae.http_client.HttpRequestMethod;
 import com.cae.http_client.HttpResponse;
-import com.cae.http_client.implementations.exceptions.RetryNeededOnExceptionThrownException;
 
 public class HttpRequestGetMethod implements HttpRequestMethod {
 
     @Override
-    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) throws RetryNeededOnExceptionThrownException {
+    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) {
         var finalRequest = FinalHttpRequestFactory.makeFinalRequestForGetMethodFrom(httpRequestModel);
         try {
             var unwrappedResponse = FinalHttpRequestExecutor.of(httpRequestModel).execute(finalRequest);
diff --git a/src/main/java/com/cae/http_client/implementations/HttpRequestPatchMethod.java b/src/main/java/com/cae/http_client/implementations/HttpRequestPatchMethod.java
@@ -2,11 +2,10 @@
 
 import com.cae.http_client.HttpRequestMethod;
 import com.cae.http_client.HttpResponse;
-import com.cae.http_client.implementations.exceptions.RetryNeededOnExceptionThrownException;
 
 public class HttpRequestPatchMethod implements HttpRequestMethod {
     @Override
-    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) throws RetryNeededOnExceptionThrownException {
+    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) {
         var finalRequest = FinalHttpRequestFactory.makeFinalRequestForPatchMethodFrom(httpRequestModel);
         try {
             var unwrappedResponse = FinalHttpRequestExecutor.of(httpRequestModel).execute(finalRequest);
diff --git a/src/main/java/com/cae/http_client/implementations/HttpRequestPostMethod.java b/src/main/java/com/cae/http_client/implementations/HttpRequestPostMethod.java
@@ -3,12 +3,11 @@
 
 import com.cae.http_client.HttpRequestMethod;
 import com.cae.http_client.HttpResponse;
-import com.cae.http_client.implementations.exceptions.RetryNeededOnExceptionThrownException;
 
 public class HttpRequestPostMethod implements HttpRequestMethod {
 
     @Override
-    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) throws RetryNeededOnExceptionThrownException {
+    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) {
         var finalRequest = FinalHttpRequestFactory.makeFinalRequestForPostMethodFrom(httpRequestModel);
         try {
             var unwrappedResponse = FinalHttpRequestExecutor.of(httpRequestModel).execute(finalRequest);
diff --git a/src/main/java/com/cae/http_client/implementations/HttpRequestPutMethod.java b/src/main/java/com/cae/http_client/implementations/HttpRequestPutMethod.java
@@ -3,12 +3,11 @@
 
 import com.cae.http_client.HttpRequestMethod;
 import com.cae.http_client.HttpResponse;
-import com.cae.http_client.implementations.exceptions.RetryNeededOnExceptionThrownException;
 
 public class HttpRequestPutMethod implements HttpRequestMethod {
 
     @Override
-    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) throws RetryNeededOnExceptionThrownException {
+    public HttpResponse execute(AbstractHttpRequestModel httpRequestModel) {
         var finalRequest = FinalHttpRequestFactory.makeFinalRequestForPutMethodFrom(httpRequestModel);
         try {
             var unwrappedResponse = FinalHttpRequestExecutor.of(httpRequestModel).execute(finalRequest);
diff --git a/src/main/java/com/cae/http_client/implementations/HttpResponseStatusCodeChecker.java b/src/main/java/com/cae/http_client/implementations/HttpResponseStatusCodeChecker.java
@@ -3,7 +3,6 @@
 import com.cae.http_client.HttpResponse;
 import com.cae.http_client.HttpResponseHandler;
 import com.cae.http_client.implementations.exceptions.NoResponseHandlersAvailableForExecutionException;
-import com.cae.http_client.implementations.exceptions.RetryNeededOnHttpStatusCodeException;
 import lombok.AccessLevel;
 import lombok.RequiredArgsConstructor;
 
@@ -13,30 +12,19 @@
 public class HttpResponseStatusCodeChecker {
 
     private final AbstractHttpRequestModel httpRequest;
-    private HttpResponse httpResponse;
 
     public static HttpResponseStatusCodeChecker of(AbstractHttpRequestModel httpRequest){
         return new HttpResponseStatusCodeChecker(httpRequest);
     }
 
-    public void checkOutHandlersFor(HttpResponse response) throws RetryNeededOnHttpStatusCodeException {
-        this.httpResponse = response;
+    public void checkOutHandlersFor(HttpResponse response) {
         var statusCodeReceived = response.getStatusCode();
-        var retryCounterForStatusCodeReceived = ofNullable(this.httpRequest.retryCountersByStatusCode.get(statusCodeReceived));
-        if (retryCounterForStatusCodeReceived.isPresent() && retryCounterForStatusCodeReceived.get().thereIsRetryAvailable()){
-            retryCounterForStatusCodeReceived.get().decreaseRetriesAvailable();
-            throw new RetryNeededOnHttpStatusCodeException(response);
-        }
-        this.executeHandlerIfAnyIsPresentForTheResponseReceived();
+        var handler = ofNullable(this.httpRequest.responseHandlersByStatusCode.get(statusCodeReceived))
+                .orElseGet(() -> this.getGenericHandler(response));
+        handler.handle(response);
     }
 
-    private void executeHandlerIfAnyIsPresentForTheResponseReceived() {
-        var statusCodeReceived = this.httpResponse.getStatusCode();
-        var handler = ofNullable(this.httpRequest.responseHandlersByStatusCode.get(statusCodeReceived)).orElseGet(this::getGenericHandler);
-        handler.handle(this.httpResponse);
-    }
-
-    private HttpResponseHandler getGenericHandler() {
-        return ofNullable(this.httpRequest.genericResponseHandler).orElseThrow(() -> new NoResponseHandlersAvailableForExecutionException(this.httpResponse));
+    private HttpResponseHandler getGenericHandler(HttpResponse response) {
+        return ofNullable(this.httpRequest.genericResponseHandler).orElseThrow(() -> new NoResponseHandlersAvailableForExecutionException(response));
     }
 }
diff --git a/src/main/java/com/cae/http_client/implementations/RetryCounterImplementation.java b/src/main/java/com/cae/http_client/implementations/RetryCounterImplementation.java
diff --git a/src/main/java/com/cae/http_client/implementations/exceptions/RetryNeededOnExceptionThrownException.java b/src/main/java/com/cae/http_client/implementations/exceptions/RetryNeededOnExceptionThrownException.java
@@ -3,7 +3,7 @@
 import lombok.Getter;
 
 @Getter
-public class RetryNeededOnExceptionThrownException extends RuntimeException{
+class RetryNeededOnExceptionThrownException extends RuntimeException{
 
     private final Class<? extends Exception> exceptionType;
 
diff --git a/src/main/java/com/cae/http_client/implementations/exceptions/RetryNeededOnHttpStatusCodeException.java b/src/main/java/com/cae/http_client/implementations/exceptions/RetryNeededOnHttpStatusCodeException.java
@@ -4,7 +4,7 @@
 import lombok.Getter;
 
 @Getter
-public class RetryNeededOnHttpStatusCodeException extends RuntimeException{
+class RetryNeededOnHttpStatusCodeException extends RuntimeException{
 
     private final HttpResponse httpResponse;
 
diff --git a/src/test/java/com/cae/http_client/CaeHttpClientTest.java b/src/test/java/com/cae/http_client/CaeHttpClientTest.java
@@ -6,27 +6,27 @@
 import org.mockito.junit.jupiter.MockitoExtension;
 
 @ExtendWith(MockitoExtension.class)
-class CaeHttpClientFactoryTest {
+class CaeHttpClientTest {
 
     @Test
     void shouldReturnFilledInstance(){
-        Assertions.assertNotNull(CaeHttpClientFactory.REQUEST_STARTER);
+        Assertions.assertNotNull(CaeHttpClient.REQUEST_STARTER);
     }
 
     @Test
     void shouldReturnSingletonInstanceWhenDirectlyCallingAttribute(){
-        var resultFromCallOne = CaeHttpClientFactory.REQUEST_STARTER;
-        var resultFromCallTwo = CaeHttpClientFactory.REQUEST_STARTER;
-        var resultFromCallThree = CaeHttpClientFactory.REQUEST_STARTER;
+        var resultFromCallOne = CaeHttpClient.REQUEST_STARTER;
+        var resultFromCallTwo = CaeHttpClient.REQUEST_STARTER;
+        var resultFromCallThree = CaeHttpClient.REQUEST_STARTER;
         Assertions.assertEquals(resultFromCallOne, resultFromCallTwo);
         Assertions.assertEquals(resultFromCallTwo, resultFromCallThree);
     }
 
     @Test
     void shouldReturnSingletonInstanceWhenCallingGetter(){
-        var resultFromCallOne = CaeHttpClientFactory.getSingletonClient();
-        var resultFromCallTwo = CaeHttpClientFactory.getSingletonClient();
-        var resultFromCallThree = CaeHttpClientFactory.getSingletonClient();
+        var resultFromCallOne = CaeHttpClient.getStarter();
+        var resultFromCallTwo = CaeHttpClient.getStarter();
+        var resultFromCallThree = CaeHttpClient.getStarter();
         Assertions.assertEquals(resultFromCallOne, resultFromCallTwo);
         Assertions.assertEquals(resultFromCallTwo, resultFromCallThree);
     }
diff --git a/src/test/java/com/cae/http_client/implementations/ExceptionThrownByHttpRequestCheckerTest.java b/src/test/java/com/cae/http_client/implementations/ExceptionThrownByHttpRequestCheckerTest.java
diff --git a/src/test/java/com/cae/http_client/implementations/HttpRequestBuilderImplementationTest.java b/src/test/java/com/cae/http_client/implementations/HttpRequestBuilderImplementationTest.java
diff --git a/src/test/java/com/cae/http_client/implementations/HttpResponseStatusCodeCheckerTest.java b/src/test/java/com/cae/http_client/implementations/HttpResponseStatusCodeCheckerTest.java

Original file line number	Diff line number	Diff line change
`@@ -5,12 +5,12 @@`
`5`	`5`	`import lombok.NoArgsConstructor;`
`6`	`6`
`7`	`7`	`@NoArgsConstructor(access = AccessLevel.PRIVATE)`
`8`		`-public class CaeHttpClientFactory {`
	`8`	`+public class CaeHttpClient {`
`9`	`9`
`10`	`10`	`public static final HttpRequestStarter REQUEST_STARTER = new HttpRequestStarterImplementation();`
`11`	`11`
`12`		`- public static HttpRequestStarter getSingletonClient(){`
`13`		`- return CaeHttpClientFactory.REQUEST_STARTER;`
	`12`	`+ public static HttpRequestStarter getStarter(){`
	`13`	`+ return CaeHttpClient.REQUEST_STARTER;`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,10 +2,9 @@`
`2`	`2`
`3`	`3`
`4`	`4`	`import com.cae.http_client.implementations.AbstractHttpRequestModel;`
`5`		`-import com.cae.http_client.implementations.exceptions.RetryNeededOnExceptionThrownException;`
`6`	`5`
`7`	`6`	`public interface HttpRequestMethod {`
`8`	`7`
`9`		`- HttpResponse execute(AbstractHttpRequestModel httpRequestModel) throws RetryNeededOnExceptionThrownException;`
	`8`	`+ HttpResponse execute(AbstractHttpRequestModel httpRequestModel);`
`10`	`9`
`11`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,5 @@`
`4`	`4`
`5`	`5`	`import java.util.Map;`
`6`	`6`
`7`		`-public interface RetriersByStatusCodeFactory extends RetriersFactory<Map<Integer, RetrierModel>> {`
	`7`	`+interface RetriersByStatusCodeFactory extends RetriersFactory<Map<Integer, RetrierModel>> {`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`package com.cae.http_client;`
`2`	`2`
`3`		`-public interface RetryCounter {`
	`3`	`+interface RetryCounter {`
`4`	`4`	`boolean thereIsRetryAvailable();`
`5`	`5`	`void decreaseRetriesAvailable();`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,5 @@ public abstract class AbstractHttpRequestModel implements HttpRequestModel {`
`20`	`20`	`protected HttpResponseHandler genericResponseHandler;`
`21`	`21`	`protected final Map<Integer, HttpResponseHandler> responseHandlersByStatusCode = new HashMap<>();`
`22`	`22`	`protected final Map<Class<? extends Exception>, ExceptionHandler> exceptionHandlersByExceptionType = new HashMap<>();`
`23`		`- protected final Map<Integer, RetryCounter> retryCountersByStatusCode = new HashMap<>();`
`24`		`- protected final Map<Class<? extends Exception>, RetryCounter> retryCountersByExceptionType = new HashMap<>();`
`25`	`23`
`26`	`24`	`}`